Makes the plugin useful for Enterprise customers#105
Makes the plugin useful for Enterprise customers#105mfauveau wants to merge 1 commit intoSparkPost:masterfrom
Conversation
mfauveau
commented
Feb 22, 2017
- Added campaign_id and ip_pool general options
- Added api_endpoint and smtp_host overrides
- When an Enterprise domain is set the return_path is automatically set (only necessary for the API method as PHP mailer will set it automatically when using SMTP)
- Added campaign_id and ip_pool general options - Added api_endpoint and smtp_host overrides - When an Enterprise domain is set the return_path is automatically set (only necessary for the API method as PHP mailer will set it automatically when using SMTP)
|
@mfauveau thanks for the PR. We'll look into it soon. |
|
@mfauveau just wanted to give you an update, I'm working with our designer to see if we can re-think plugin settings page to add these bunch of fields in a way that makes clear sense to both enterprise and non-enterprise users. also trying to address a few current UI concerns in the same iteration. meanwhile, it'll be awesome if you can add a few unit tests for your changes. |
|
Sorry for the delay @rajumsys, I've been very busy. I've never written tests for Wordpress so even though I'm willing to help I'm afraid that would take too much of my time. Unless you can give me some pointers? |
|
@mfauveau no problem. i can try help if you've any question. i think you can start looking into a few tests we already have here https://github.com/SparkPost/wordpress-sparkpost/blob/master/tests/specs/test-mailer.http.class.php. |
|
@mfauveau could you look into the tests? as we've a new UI work-in-progress we can probably plan this for around v3.5x |
|
Hi @rajumsys I apologize for the delay. I've been swamped and cannot find time to write the tests at this time. |
|
@mfauveau no problem. you can take your time if you want to do it later. we've also worked on a new UI and we believe it'll make more sense to have enterprise related fields in the new UI. we'll be working on that in coming days. |
|
@mfauveau a new interface (tabbed) is just merged to master. do you think you'll be able to update this PR? i've two thoughts
|
Remove the border-style set on btn