MiniExpr no longer supports list indexing#257
Merged
SpaceManiac merged 2 commits intoSpaceManiac:masterfrom Mar 24, 2021
sohpeach:miniexpr
Merged
MiniExpr no longer supports list indexing#257SpaceManiac merged 2 commits intoSpaceManiac:masterfrom sohpeach:miniexpr
SpaceManiac merged 2 commits intoSpaceManiac:masterfrom
sohpeach:miniexpr
Conversation
SpaceManiac
approved these changes
Mar 24, 2021
Owner
SpaceManiac
left a comment
There was a problem hiding this comment.
As far as I can tell, there was no BYOND change and this code was wrong all along.
j-awn
pushed a commit
to j-awn/SpacemanDMM
that referenced
this pull request
Apr 1, 2021
I noticed that this was different from BYOND's behaviour where `new x[y]` actually compiles as `(new x)[y]`. The same behaviour applies for `new x?[y]` so I don't anticipate the code I am removing being needed for that. I confirmed that BYOND has been compiling it this way since at least 513.1490, so if it changed it was long ago. [SpaceManiac] As far as I can tell, there was no BYOND change and this code was wrong all along.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that this was different from BYOND's behaviour where
new x[y]actually compiles as(new x)[y]. The same behaviour applies fornew x?[y]so I don't anticipate the code I am removing being needed for that.I confirmed that BYOND has been compiling it this way since at least 513.1490, so if it changed it was long ago.