Add 514 rgb() support#254
Merged
SpaceManiac merged 22 commits intoSpaceManiac:masterfrom Mar 19, 2021
Merged
Conversation
SpaceManiac
reviewed
Mar 15, 2021
consistent spacing
ZeWaka
commented
Mar 16, 2021
ZeWaka
commented
Mar 16, 2021
SpaceManiac
approved these changes
Mar 19, 2021
Owner
SpaceManiac
left a comment
There was a problem hiding this comment.
Accepting this functionality as-is + some non-functional code cleanup. Looking in to extra tests for weirdo cases.
j-awn
pushed a commit
to j-awn/SpacemanDMM
that referenced
this pull request
Apr 1, 2021
Allows for `rgb()` with arguments of form `[r,g,b|h,s,[v|l|y]],(a),(space)` Also allows the full names of the arguments. Technically, BYOND supports just the first letter so `halifax` works for `hue` but fuck that. Also now lints to see if the values are in the valid ranges. Co-authored-by: Tad Hardesty <tad@platymuus.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows for
rgb()with arguments of form[r,g,b|h,s,[v|l|y]],(a),(space)Also allows the full names of the arguments.
Technically, BYOND supports just the first letter so
halifaxworks forhuebut fuck that.Also now lints to see if the values are in the valid ranges.