Skip to content

Optimize map rendering.#242

Merged
SpaceManiac merged 5 commits intoSpaceManiac:masterfrom
PJB3005:21-02-03-optimize-maprender
Feb 17, 2021
Merged

Optimize map rendering.#242
SpaceManiac merged 5 commits intoSpaceManiac:masterfrom
PJB3005:21-02-03-optimize-maprender

Conversation

@PJB3005
Copy link
Copy Markdown
Contributor

@PJB3005 PJB3005 commented Feb 3, 2021

It is much faster now, way less terrible blitting code.

@SpaceManiac
Copy link
Copy Markdown
Owner

Reposting from Discord for future reference:

PJB:

is it a problem that I changed the internal representation of Image to a Vec<Rgba8> which is a breaking change (and isn't a 2D array for easy handling)?

SpaceManiac:

It's fine as long as the project compiles/passes tests/works. I make no API stability guarantees if used as a library
*and if the change is good

PJB3005 and others added 3 commits February 4, 2021 13:13
I should've installed IntelliJ
This was me experimenting with some stuff.
@SpaceManiac
Copy link
Copy Markdown
Owner

Renders MetaStation about 9% faster for me which seems worthwhile

@SpaceManiac SpaceManiac merged commit e078010 into SpaceManiac:master Feb 17, 2021
j-awn pushed a commit to j-awn/SpacemanDMM that referenced this pull request Apr 1, 2021
It is much faster now, way less terrible blitting code.

---
SpaceManiac's benchmarks indicate about 9% speedup when rendering MetaStation with `--release` on.
@SpaceManiac SpaceManiac added this to the suite v1.7 milestone May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants