Skip to content

Time to merge#339

Merged
lGuillaume124 merged 21 commits into
Sonerezh:developmentfrom
gs11:development-new
Aug 17, 2018
Merged

Time to merge#339
lGuillaume124 merged 21 commits into
Sonerezh:developmentfrom
gs11:development-new

Conversation

@lGuillaume124

Copy link
Copy Markdown
Contributor

It's time to backport the work from the main fork.

gs11 and others added 21 commits February 24, 2018 11:06
For mp3 files, the "Part Of a Set" tag (`TPOS`) can be either a single
number, or two numbers separated by a '/' [1].

Sonerezh always wanted two numbers separated by a '/', and, for ogg
files, only filled the disc tag if both DISCNUMBER and DISCTOTAL existed.

This fix does two things:
1. For ogg files, DISCTOTAL is now optional
2. Handle both formats, i.e. w/ and w/o '/'

[1] http://id3.org/id3v2.3.0
Detect DISCNUMBER tag without DISCTOTAL
Adding a translation file for German Translation of the web interface

Add German locale

Fix indetation

Fix typo

Fix indent

Applying 4 space coding convention to indentation

Fixes some extra whitespace and some typos

Fixing the rest of extra whitespace
@MightyCreak

Copy link
Copy Markdown
Contributor

Thank you thank you thank you!

@lGuillaume124

Copy link
Copy Markdown
Contributor Author

You're welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants