Replace kernel/lib.c with musl-derived implementations#166
Merged
mato merged 1 commit intoSolo5:masterfrom Mar 9, 2017
Merged
Conversation
This change replaces the functions defined in kernel/lib.c with musl-derived implementations, which are then also used by the tests. This change is motivated by an immediate need for known-good implementations of these functions. I had not reviewed the original implementations until running into major bugs in them today. Eventually we want a better integration of "nolibc" into both kernel (Solo5) and application (test) code, so this particular arrangement is temporary. For simplicitly the musl-derived implementations have been stripped down to use the generic "fallback" implementations where possible.
Member
Author
|
@djwillia @ricarkol The TL;DR of this PR is: "spot the bugs in |
Member
Author
|
Merging this as the existing implementations need to be terminated with extreme prejudice. |
Contributor
|
do you plan to do a solo5 release containing these changes? would be appreciated. I tested compilation on FreeBSD (CURRENT with clang-3.9, and 11 with clang-3.8) successfully. |
Member
Author
|
On Thursday, 09.03.2017 at 05:19, Hannes Mehnert wrote:
do you plan to do a solo5 release containing these changes? would be appreciated. I tested compilation on FreeBSD (CURRENT with clang-3.9, and 11 with clang-3.8) successfully.
Yes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change replaces the functions defined in kernel/lib.c with
musl-derived implementations, which are then also used by the tests.
This change is motivated by an immediate need for known-good
implementations of these functions. I had not reviewed the original
implementations until running into major bugs in them today. Eventually
we want a better integration of "nolibc" into both kernel (Solo5) and
application (test) code, so this particular arrangement is temporary.
For simplicity the musl-derived implementations have been stripped down
to use the generic "fallback" implementations where possible.