Closed
Conversation
This is modified copy of the freestanding nolibc. What has been modified is the removal of the fmt_fp function of vfprintf.c (with their corresponding flags e, f, g and ) and the dependency on openlibm (which means <math.h> is a noop). The provided test cases tests solo5 malloc.
Member
|
Historic, closing. malloc has since gone from the public API, so the immediate motivation for this is no longer there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is modified copy of the freestanding nolibc,
per my understanding of the discussion in the bug
report.
What has been modified is the removal of the fmt_fp
function of vfprintf.c (with their corresponding flags
e, f, g and ) and the dependency on openlibm (which
means <math.h> is a noop).
The provided test cases tests solo5 memory allocation
by allocating various strings, growing them and deleting
them non-consecutively, with an eye on memory corruption.
I believe that was the main solo5 API left untested.
If this is in the right direction, I can expand this PR to remove
the code clones from nolibc in the other test cases, although
it might be better to restructure the test harness to link to this,
which might be better left to core contributors. Just let me know.