src/SettingsBundle/DTO/Config.php (1)

14-23: Minor ergonomics: default nullable args to null.
Reduces noise at call sites where many pass null explicitly.

-final class Config
+final class Config
 {
     public function __construct(
         public readonly string $key,
-        public readonly mixed $value,
-        public readonly ?string $description,
-        public readonly ?string $formType,
+        public readonly mixed $value = null,
+        public readonly ?string $description = null,
+        public readonly ?string $formType = null,
     ) {
     }
 }

src/SettingsBundle/Config/ProviderInterface.php (1)

16-23: Tighten phpdoc for static analysis.
Indicate a numerically indexed list for clearer tooling.

     /**
-     * @param array{company_name?: string|null, currency?: string|null} $data
-     *
-     * @return Config[]
+     * @param array{company_name?: string|null, currency?: string|null} $data
+     * @return list<Config>
      */
     public function provide(array $data): array;

src/CoreBundle/Config/SystemConfigProvider.php (1)

29-35: Use TelType for phone number input.
Improves semantics and built-in validation/UX for phone fields.

-            new Config('system/company/contact_details/phone_number', null, null, TextType::class),
+            new Config('system/company/contact_details/phone_number', null, null, \Symfony\Component\Form\Extension\Core\Type\TelType::class),

src/InvoiceBundle/Config/ConfigProvider.php (1)

23-33: Silence PHPMD for unused $data.
Interface requires the parameter; this implementation doesn’t use it. Suppress the warning.

 final class ConfigProvider implements ProviderInterface
 {
+    /**
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
     public function provide(array $data): array
     {
         return [

Alternative: unset($data); as the first line in the method.

src/QuoteBundle/Config/ConfigProvider.php (1)

23-33: Silence PHPMD for unused $data (interface requirement) and document return type.

Keep the signature, but add an UnusedFormalParameter suppression and a precise return phpdoc.

 final class ConfigProvider implements ProviderInterface
 {
-    public function provide(array $data): array
+    /**
+     * @return list<Config>
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
+    public function provide(array $data): array
     {
         return [

src/CoreBundle/Company/DefaultData.php (2)

66-80: Add idempotency guard to avoid duplicate settings on re-run.

If DefaultData can run more than once, check for existing keys before persisting or upsert.

-                $this->em->persist($settingEntity);
+                // Skip if key already exists
+                if (! $this->em->getRepository(Setting::class)->findOneBy(['key' => $config->key])) {
+                    $this->em->persist($settingEntity);
+                }

---

47-64: Tighten annotations and consider deterministic provider order.

• The JsonException @throws may be stale for createAppConfig(); drop or update if not thrown here.
• If provider order matters, consider ordering via tag priority.

-    /**
-     * @param array{currency: string} $data
-     * @throws JsonException
-     */
+    /**
+     * @param array{currency: string} $data
+     */
     private function createAppConfig(Company $company, array $data): void

Optional ordering (if using tags):

#[TaggedIterator(ProviderInterface::class/*, defaultPriorityMethod: 'getPriority'*/)]

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro