src/SettingsBundle/Twig/Components/Settings.php (1)

41-52: Make settingIconMap readonly and manually verify your Font Awesome version

• Apply this diff to prevent mutation and keep PHPStan happy:

-    /** @var array<string, string> */
-    public array $settingIconMap = [
+    /** @var array<string, string> */
+    public readonly array $settingIconMap = [
         'company' => 'building',
         'invoice' => 'file-invoice',
         'quote'   => 'file-text-o',
         'email'   => 'envelope',
         'payment' => 'credit-card',
         'tax'     => 'balance-scale',
         'system'  => 'cog',
     ];

• We found multiple usages of file-text-o in your Twig templates—this is a Font Awesome 4 icon name. If your project uses FA 5+ (or newer), you’ll need to swap in the updated icon class (e.g., file-alt for file-text-o, scale-balanced or balance-scale depending on your FA version).
• I wasn’t able to locate the FA package/version in composer.json, package.json, or lockfiles. Please confirm which Font Awesome version you’re shipping (check composer.lock, package-lock.json, webpack config, etc.) and update any legacy icon names accordingly.

src/CoreBundle/Repository/CompanyRepository.php (1)

57-71: Optional: avoid SELECT by using getReference when existence check isn’t required

Current approach loads the entity, then removes. If you don’t need to detect "not found" explicitly, using a reference avoids an extra query.

-        $company = $this->find($companyId);
-
-        if (! $company instanceof Company) {
-            return;
-        }
-
-        $this->getEntityManager()->remove($company);
+        $em = $this->getEntityManager();
+        $companyRef = $em->getReference(Company::class, $companyId);
+        $em->remove($companyRef);
         $this->getEntityManager()->flush();

Pros: fewer queries. Cons: you lose the explicit "not found" branch (DELETE will no-op if row doesn’t exist).

src/CoreBundle/Action/DeleteCompany.php (2)

47-47: Use a translatable flash key

Keep flash messages consistent with the rest of the app using translation keys.

-        $this->addFlash('success', 'Company deleted successfully.');
+        $this->addFlash('success', 'company.deleted.success');

---

49-50: Use 303 See Other for POST-redirect

303 is the recommended status for redirect-after-POST.

-        return $this->redirectToRoute('_select_company');
+        return $this->redirectToRoute('_select_company', [], Response::HTTP_SEE_OTHER);

assets/controllers/delete-company-controller.ts (1)

16-18: Nit: add disconnect() to clear references

Not required, but cleaning up helps avoid stale references.

     connect() {
         this.modal = $(this.modalTarget);
     }
+
+    disconnect() {
+        this.modal = null;
+    }

src/CoreBundle/Entity/Company.php (2)

95-96: Naming consistency: pluralize credit collection

For a OneToMany to Credit, consider $credits for clarity and consistency.

---

134-138: Optional: initialize new collections to avoid typed property access issues

If any of these collections are ever accessed, uninitialized typed properties will throw. Initialize them in the constructor.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Learnt from: pierredup
PR: SolidInvoice/SolidInvoice#1759
File: src/UserBundle/Resources/views/Layout/_partial/nav.html.twig:1-46
Timestamp: 2025-06-01T18:20:04.058Z
Learning: In SolidInvoice project, routes are defined in PHP routing configuration files like `src/UserBundle/Resources/config/routing.php`, not just in YAML files or PHP annotations.

src/SettingsBundle/Tests/Twig/Components/__snapshots__/SettingsTest__testRenderComponent__1.html (5)

15-15: Verify Font Awesome version and class prefixes for new icons

fa-file-invoice is not available in FA4 and in FA5+ typically uses fas fa-file-invoice. Ensure the project’s icon set matches these classes; otherwise the icon won’t render. Align all icons to the same FA version/prefix.

Also applies to: 21-21, 27-27

---

567-567: Non-standard class card-danger – use Bootstrap-supported variants

card-danger isn’t a standard class in Bootstrap 4/5. Prefer border-danger (and optionally text-danger/bg-*) for consistent styling across themes.

- <div class="card mb-3 card-danger">
+ <div class="card mb-3 border-danger">

---

586-586: Modal accessibility improvements

Add aria-modal="true" to the modal container and ensure initial focus is handled when opening (Stimulus can call focus() on the input target).

- <div class="modal fade" id="deleteCompanyModal" tabindex="-1" role="dialog" aria-labelledby="deleteCompanyModalLabel" aria-hidden="true" data-delete-company-target="modal">
+ <div class="modal fade" id="deleteCompanyModal" tabindex="-1" role="dialog" aria-labelledby="deleteCompanyModalLabel" aria-modal="true" aria-hidden="true" data-delete-company-target="modal">

Also consider aria-describedby referencing the warning text for additional context.

Also applies to: 590-592, 611-618

---

615-617: Confirm action must POST with CSRF and provide UX feedback

The confirm button is handled via Stimulus. Ensure it submits a POST to the delete route with a valid CSRF token and handles failures (disable button while submitting, show spinner, display error).

If not already present, consider a hidden form as a progressive enhancement:

<form id="delete-company-form" method="post" action="{{ path('_delete_company') }}" class="d-none">
  <input type="hidden" name="_token" value="{{ csrf_token('delete_company') }}">
</form>

Stimulus can document.getElementById('delete-company-form').submit() once validated.

---

570-579: Internationalization of new UI strings

New strings (“Danger Zone”, warnings, labels, buttons) should be translatable. Ensure the Twig template wraps them with the translator (e.g., {{ '...'|trans }}) and add catalog entries.

Also applies to: 591-596, 601-609, 612-617

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

src/SettingsBundle/Tests/Twig/Components/__snapshots__/SettingsTest__testRenderComponent__1.html (2)

599-601: Bootstrap 4 dismissal/close markup — LGTM

You reverted to .close and data-dismiss="modal" consistent with BS4. Good fix.

Also applies to: 620-622

---

587-587: Hardcoded company name — make dynamic and properly escaped

The confirmation attribute and label use a hardcoded name “SolidInvoice”. Use the actual company name from context, escaped for attribute/text.

Conceptual Twig changes:

- <div class="form-group" data-controller="delete-company" data-delete-company-company-name-value="SolidInvoice">
+ <div class="form-group"
+      data-controller="delete-company"
+      data-delete-company-company-name-value="{{ company.name|e('html_attr') }}">
@@
-     <p class="fw-bold text-danger">SolidInvoice</p>
+     <p class="font-weight-bold text-danger">{{ company.name|e }}</p>

Note: Update the template; snapshots will follow.

Also applies to: 611-611

src/SettingsBundle/Tests/Twig/Components/__snapshots__/SettingsTest__testRenderComponent__1.html (2)

616-616: Small UX hardening: disable browser assistance on confirmation field

Prevent autocomplete/capitalization/spellcheck from interfering with exact match validation.

-                                            <input type="text" class="form-control" id="companyNameConfirmation" name="company_name" form="deleteCompanyForm" data-delete-company-target="companyNameInput" data-action="input->delete-company#validateInput" placeholder="Enter company name to confirm">
+                                            <input type="text" class="form-control" id="companyNameConfirmation" name="company_name" form="deleteCompanyForm" data-delete-company-target="companyNameInput" data-action="input->delete-company#validateInput" placeholder="Enter company name to confirm" autocomplete="off" autocapitalize="off" spellcheck="false">

---

581-586: Consider marking user-facing strings for translation

Make Danger Zone copy, button labels, and warnings translatable to align with the rest of the app.

Example:

• Replace literals with {{ 'settings.danger_zone.title'|trans }}, {{ 'settings.delete_company.button'|trans }}, etc.
• I can propose keys and update the template + translations if helpful.

Also applies to: 603-610, 620-629

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro