Bug/21 tag update fix#23
Closed
OneShoeBoy wants to merge 5 commits into
Closed
Conversation
…d of appending new tags
…ng referenced via '[#N|...]'
… using +, and tag overwriting when entity is redefined.
Merged
Contributor
Author
|
Superseded by #23 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #27
Updated package.json to fix dependency and npm audit errors.Partially fixes #21Re-define with new tagsAdd tag using +Remove tag using -Reference entity using #The following have not been fixed:Show just the change (assumes other tags persist)Not sure if this is possible while also being able to redefine and overwrite the entityUse explicit updates: [N:Jonah|friendly -> hostile]Will implement laterTODO:Look at refactoring parser.ts , lots of replicated code throughout the file that could be pulled into fewer methods and interfaces.Implement explicit updatesImprove tag updates to allow for direct operations on numbers, e.g. [PC:myPC|HP +1]Implement status updates (e.g. Definition: [N:Jonah|status: uninjured, friendly] -> Update: [N:Jonah|status: -friendly|)