BUG: Update VTK backporting OpenVR rendering fix when HMD inside the volume#7507
Merged
jcfr merged 1 commit intoSlicer:mainfrom Dec 23, 2023
Conversation
…volume
This addresses proper rendering, particularly by `vtkOpenGLGPUVolumeRaycastMapper`,
when the head-mounted display (HMD) is positioned inside the volume. The issue is
resolved by ensuring correct computation of the plane frustum when the camera is
tracking the HMD and is positioned inside the volume.
The changes listed below impact the following VTK modules:
* `Rendering/VR`
* `Rendering/OpenVR`
* `Rendering/OpenXR`
List of VTK changes:
```
$ git shortlog c69cf77a6..7767cabe4 --no-merges
Sankhesh Jhaveri (3):
[Backport MR-10783] VR: Move the TrackHMD flag to the camera
[Backport MR-10783] VR: Deprecate vtkVRRenderWindow::TrackHMD
[Backport MR-10783] VR: Provide stereo projection transforms for rendering
```
Co-authored-by: Sankhesh Jhaveri <sankhesh.jhaveri@kitware.com>
Co-authored-by: Lucas Gandel <lucas.gandel@kitware.com>
a658821 to
6448c27
Compare
Member
Author
|
Since the change has been tested locally and confirmed to fix issue KitwareMedical/SlicerVirtualReality#125 ✅, moving forward with the integration 🚀 |
This was referenced Dec 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses proper rendering, particularly by
vtkOpenGLGPUVolumeRaycastMapper, when the head-mounted display (HMD) is positioned inside the volume. The issue is resolved by ensuring correct computation of the plane frustum when the camera is tracking the HMD and is positioned inside the volume.The changes listed below impact the following VTK modules:
Rendering/VRRendering/OpenVRRendering/OpenXRFixes:
For more details:
OpenXR: Fix near plane clipping with camera inside volumeVR: Accommodate separate eye transformsList of VTK changes:
cc: @sankhesh @LucasGandel