[slicer-v9.2.20230607-1ff325c54-2] Backport VR fix for correct volume rendering when HMD inside the volume#48
Merged
jcfr merged 3 commits intoSlicer:slicer-v9.2.20230607-1ff325c54-2from Dec 23, 2023
Conversation
Track HMD affects whether the camera is tracking the head mounted display or not. Moving this flag to the vtkVRCamera is fitting for this purpose to allow multiple cameras in the VR world. When performing hardware picking, the camera is moved to the wand and TrackHMD is disabled to ensure that the scene doesn't change. Merge-request: vtk/vtk!10783
Merge-request: vtk/vtk!10783
…ering Co-authored-by: Lucas Gandel <lucas.gandel@kitware.com> Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com> Merge-request: vtk/vtk!10783
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses proper rendering, particularly by
vtkOpenGLGPUVolumeRaycastMapper, when the head-mounted display (HMD) is positioned inside the volume. The issue is resolved by ensuring correct computation of the plane frustum when the camera is tracking the HMD and is positioned inside the volume.For more details:
OpenXR: Fix near plane clipping with camera inside volumeVR: Accommodate separate eye transformsFixes: