Update CondHasScoreboardTag.java#8248
Merged
APickledWalrus merged 2 commits intoSkriptLang:dev/patchfrom Nov 2, 2025
Merged
Conversation
UnderscoreTud
approved these changes
Oct 22, 2025
erenkarakal
approved these changes
Oct 22, 2025
erenkarakal
approved these changes
Oct 22, 2025
Absolutionism
approved these changes
Oct 22, 2025
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
using
if x has scoreboard tags "y" or "z"would randomly check only whether x had y or only whether x had z as a 50/50 chance, rather than checking whether it had y or z at all. This was due to a getArray call being used instead of getAll + SimpleExpression.check()Solution
Uses SimpleExpression.check() to ensure the OR/AND status of the list is properly respected.
Testing Completed
Supporting Information
Completes: none
Related: none