Remove deprecated block data methods#8240
Merged
sovdeeth merged 1 commit intoSkriptLang:dev/patchfrom Oct 16, 2025
Merged
Conversation
Removed two lines related to block data changes that have been deprecated since 1.6.2, which initiate CraftLegacy WHILE THE SERVER IS RUNNING when a bucket is emptied or filled. Obviously, we don't support 1.6.2, so there's no compatibility issues to worry about when removing this. Hopefully.
Contributor
|
Seems fine to me, note for next time - Target dev/patch or dev/feature depending on the changes, not master |
Contributor
Author
alright, noted |
This was
linked to
issues
Oct 16, 2025
sovdeeth
approved these changes
Oct 16, 2025
TheMug06
approved these changes
Oct 16, 2025
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Buckets are my worst nightmare. When emptying or filling a bucket, Skript will attempt to set block data on it via a method that has been deprecated since 1.6.2. ONE POINT SIX. that's like. at least fifty versions behind what is currently the minimum version.
Since this method is so old, it's no longer natively supported by CraftBukkit, and instead initializes CraftLegacy. Since this happens the first time (in a session) the bucket is filled or emptied, CraftLegacy is not initialized on startup, but rather when this happens, and it causes anywhere from 5 to 30 seconds of lag.
tl;dr legacy bucket methods are causing lag during runtime
Solution
just nuke it lmao
Testing Completed
I have NO idea what script was causing this, but when I added the patched version to the server it was fixed. If this needs further testing let me know and I'll do some more extensive testing.
Completes: #6968, #7560,
Related: #6641