Properly parse exprsecs in function calls#8199
Merged
sovdeeth merged 1 commit intoSkriptLang:dev/patchfrom Sep 21, 2025
Merged
Conversation
Absolutionism
approved these changes
Sep 21, 2025
Efnilite
approved these changes
Sep 21, 2025
sovdeeth
added a commit
that referenced
this pull request
Oct 1, 2025
* Swap reset and delete errors in EffChange (#8177) swap reset and delete errors * Fix improper grammar in update block syntax (#8072) Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com> * Fix Incorrect Variable Change Queue Processing (#8182) Fix incorrect change processing order * Change registerExpression() parameter name (#8180) change parameter name * Move EvtRealTime to main thread (#8185) * Fix type-aware function parsing for functions with only optional arguments (#8189) Account for functions with all optional parameters * Properly parse exprsecs in function calls (#8199) modify section context when parsing functions * add runtime error when EffSort aborts due to null values. * catch runtime errors
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
) * Swap reset and delete errors in EffChange (SkriptLang#8177) swap reset and delete errors * Fix improper grammar in update block syntax (SkriptLang#8072) Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com> * Fix Incorrect Variable Change Queue Processing (SkriptLang#8182) Fix incorrect change processing order * Change registerExpression() parameter name (SkriptLang#8180) change parameter name * Move EvtRealTime to main thread (SkriptLang#8185) * Fix type-aware function parsing for functions with only optional arguments (SkriptLang#8189) Account for functions with all optional parameters * Properly parse exprsecs in function calls (SkriptLang#8199) modify section context when parsing functions * add runtime error when EffSort aborts due to null values. * catch runtime errors
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
) * Swap reset and delete errors in EffChange (SkriptLang#8177) swap reset and delete errors * Fix improper grammar in update block syntax (SkriptLang#8072) Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com> * Fix Incorrect Variable Change Queue Processing (SkriptLang#8182) Fix incorrect change processing order * Change registerExpression() parameter name (SkriptLang#8180) change parameter name * Move EvtRealTime to main thread (SkriptLang#8185) * Fix type-aware function parsing for functions with only optional arguments (SkriptLang#8189) Account for functions with all optional parameters * Properly parse exprsecs in function calls (SkriptLang#8199) modify section context when parsing functions * add runtime error when EffSort aborts due to null values. * catch runtime errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Having a section expression in a function call would not properly claim the section, leading to the section never running:
would broadcast 15 seconds, not 1 second.
Solution
Modifies sectioncontext when parsing EffFunctionCall, so the expr sec can properly claim the section.
Testing Completed
Added a regression test.
Supporting Information
Completes: none
Related: none