Skip to content

Feature/players listed#8101

Merged
sovdeeth merged 14 commits intoSkriptLang:dev/featurefrom
TheLimeGlass:feature/players-listed
Sep 21, 2025
Merged

Feature/players listed#8101
sovdeeth merged 14 commits intoSkriptLang:dev/featurefrom
TheLimeGlass:feature/players-listed

Conversation

@TheLimeGlass
Copy link
Copy Markdown
Contributor

Problem

Skript can't get the tablisted players, and paper has api for it.

Solution

added, a new expression using the isListed api.

Testing Completed

tested syntax, it wok


Completes: none
Related: none

@TheLimeGlass TheLimeGlass requested a review from a team as a code owner August 1, 2025 05:01
@TheLimeGlass TheLimeGlass requested review from Efnilite and cheeezburga and removed request for a team August 1, 2025 05:01
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Aug 1, 2025
Copy link
Copy Markdown
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm rather disappointed in the lack of effort in the PR description, but thank you for at least filling it out. Please be sure to put some effort into the description in any future PRs you make.

@TheLimeGlass TheLimeGlass requested a review from sovdeeth August 1, 2025 09:29
@TheLimeGlass
Copy link
Copy Markdown
Contributor Author

TheLimeGlass commented Aug 1, 2025

I'm rather disappointed in the lack of effort in the PR description, but thank you for at least filling it out. Please be sure to put some effort into the description in any future PRs you make.

That is not how you should be talking to contributors, Especially core developers.

@skriptlang-automation skriptlang-automation bot added needs reviews A PR that needs additional reviews and removed needs reviews A PR that needs additional reviews labels Aug 1, 2025
@TheLimeGlass TheLimeGlass requested a review from Burbulinis August 1, 2025 11:20
@sovdeeth sovdeeth added the feature Pull request adding a new feature. label Aug 1, 2025
…java

Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
@skriptlang-automation skriptlang-automation bot added feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. and removed needs reviews A PR that needs additional reviews labels Aug 1, 2025
@skriptlang-automation skriptlang-automation bot removed the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Aug 2, 2025
TheLimeGlass and others added 2 commits August 4, 2025 06:34
…java

Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
…java

Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
@TheLimeGlass TheLimeGlass requested a review from Efnilite August 4, 2025 12:34
@skriptlang-automation skriptlang-automation bot added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Aug 4, 2025
@Absolutionism Absolutionism moved this to Awaiting Merge in 2.13 Releases Aug 5, 2025
@sovdeeth sovdeeth merged commit 54c1918 into SkriptLang:dev/feature Sep 21, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done - Awaiting Release in 2.13 Releases Sep 21, 2025
@skriptlang-automation skriptlang-automation bot added completed The issue has been fully resolved and the change will be in the next Skript update. and removed feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. labels Sep 21, 2025
@TheLimeGlass TheLimeGlass deleted the feature/players-listed branch October 2, 2025 08:03
@sovdeeth sovdeeth moved this from Done - Awaiting Release to Done - Released in 2.13 Releases Oct 15, 2025
erenkarakal pushed a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
* Adds tablisted view players

* Add the to the syntax because of 2.12 conflictions

* requested changes

* Add keywords

* requested changes

* requested changes

* Remove 1.19.4 method checks

* Remove 1.19.4 method checks

* Update src/main/java/ch/njol/skript/expressions/ExprTablistedPlayers.java

Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>

* Update src/main/java/ch/njol/skript/expressions/ExprTablistedPlayers.java

Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>

* Update src/main/java/ch/njol/skript/expressions/ExprTablistedPlayers.java

Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>

* Update src/main/java/ch/njol/skript/expressions/ExprTablistedPlayers.java

---------

Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com>
Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
erenkarakal pushed a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
* Adds tablisted view players

* Add the to the syntax because of 2.12 conflictions

* requested changes

* Add keywords

* requested changes

* requested changes

* Remove 1.19.4 method checks

* Remove 1.19.4 method checks

* Update src/main/java/ch/njol/skript/expressions/ExprTablistedPlayers.java

Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>

* Update src/main/java/ch/njol/skript/expressions/ExprTablistedPlayers.java

Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>

* Update src/main/java/ch/njol/skript/expressions/ExprTablistedPlayers.java

Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>

* Update src/main/java/ch/njol/skript/expressions/ExprTablistedPlayers.java

---------

Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com>
Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

completed The issue has been fully resolved and the change will be in the next Skript update. feature Pull request adding a new feature.

Projects

No open projects
Status: Done - Released

Development

Successfully merging this pull request may close these issues.

5 participants