Skip to content

Equippable components#7194

Merged
Absolutionism merged 65 commits intoSkriptLang:dev/featurefrom
Absolutionism:dev/EquippableComponents
Sep 30, 2025
Merged

Equippable components#7194
Absolutionism merged 65 commits intoSkriptLang:dev/featurefrom
Absolutionism:dev/EquippableComponents

Conversation

@Absolutionism
Copy link
Copy Markdown
Contributor

@Absolutionism Absolutionism commented Nov 4, 2024 •
edited
Loading

Description

This PR aims to add support for the upcoming Equippable Components to Skript. Allowing users to modify the components of an item and create new equippable components with features such as: Dispensable, Damageable, Swappable, allowed entities, equip sound, and many more.

This will be marked as draft due to Equippable Components being ApiStatus.Experimental at this time.
Open to any syntax changes.

Target Minecraft Versions: any
Requirements: none
Related Issues: none

@Absolutionism Absolutionism marked this pull request as draft November 4, 2024 23:19
EquipableMC
EquipableMC suggested changes Nov 4, 2024
View reviewed changes
@Efnilite Efnilite added the feature Pull request adding a new feature. label Nov 5, 2024
@Absolutionism Absolutionism marked this pull request as ready for review November 10, 2024 18:32
@Absolutionism
Update
01b3fe7
@Absolutionism
Merge branch 'dev/feature' into dev/EquippableComponents
70c7186
@Absolutionism
Merge remote-tracking branch 'upstream/dev/feature' into dev/Equippab…
d78a8f2 
…leComponents

# Conflicts:
#	src/main/java/ch/njol/skript/Skript.java
#	src/main/resources/lang/default.lang
Moderocky
Moderocky approved these changes Nov 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Moderocky Moderocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sovdeeth
Copy link
Copy Markdown
Member

sovdeeth commented Dec 8, 2024

Can you explain the reasoning behind making the equippable component a new type? Why not just have all the syntaxes act on items, like you already have them doing?

@Absolutionism
Copy link
Copy Markdown
Contributor Author

Absolutionism commented Dec 9, 2024

Can you explain the reasoning behind making the equippable component a new type? Why not just have all the syntaxes act on items, like you already have them doing?

I believe having this new type will be beneficial for storing template equippable components. I personally feel it to be more intuitive

@Absolutionism
Merge remote-tracking branch 'upstream/dev/feature' into dev/Equippab…
2500976 
…leComponents

# Conflicts:
#	src/main/java/ch/njol/skript/util/slot/EquipmentSlot.java
@Absolutionism
Merge branch 'dev/feature' into dev/EquippableComponents
8f944a2
@Absolutionism
Merge remote-tracking branch 'upstream/dev/feature' into dev/Equippab…
256781a 
…leComponents

# Conflicts:
#	src/main/java/ch/njol/skript/Skript.java
#	src/main/java/ch/njol/skript/bukkitutil/SoundUtils.java
#	src/main/resources/lang/default.lang
@Absolutionism
Update
e250c95
@Absolutionism
Merge branch 'dev/feature' into dev/EquippableComponents
7e59693
@Burbulinis Burbulinis mentioned this pull request Jan 19, 2025
Closed
@Absolutionism
Merge remote-tracking branch 'upstream/dev/feature' into dev/Equippab…
cc57b63 
…leComponents

# Conflicts:
#	src/main/java/ch/njol/skript/Skript.java
#	src/main/java/ch/njol/skript/util/slot/EquipmentSlot.java
#	src/main/resources/lang/default.lang
@Absolutionism Absolutionism requested review from a team as code owners May 11, 2025 07:01
@Absolutionism Absolutionism requested review from UnderscoreTud and sovdeeth and removed request for a team May 11, 2025 07:01
APickledWalrus
APickledWalrus requested changes Sep 10, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Perhaps I could persuade you to use Registration API for syntax? 🙂

APickledWalrus
APickledWalrus requested changes Sep 30, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost ready

@github-project-automation github-project-automation bot moved this from In Review to Awaiting Merge in 2.13 Releases Sep 30, 2025
@Absolutionism Absolutionism merged commit 8f657a8 into SkriptLang:dev/feature Sep 30, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done - Awaiting Release in 2.13 Releases Sep 30, 2025
@sovdeeth sovdeeth moved this from Done - Awaiting Release to Done - Released in 2.13 Releases Oct 15, 2025
erenkarakal pushed a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
@Absolutionism @erenkarakal
Equippable components (SkriptLang#7194)
fdf786c 
* Starter Commit

* PR ready

* remove "runtime"

* Changes

* Update

* Update

* Overhaul

* Update CondEquipCompInteract.java

* Requested Changes

* Partial Changes

* Update EquippableComponents.sk

* revert

* Record Usage

* Partial Changes

* More Changes

* Changes

* Requested Changes

* Update EquippableComponents.sk

* Update EquippableComponents.sk

* Adooblus Changes

* Update EquippableExperiment.java

* Update Experiment Class  Name

* Requested Changes

* Cloneable Changes

* Update EquippableModule.java

* Update ItemComponentModule.java

* Partial Update

Experiencing some issues, need to see if incorrect merge

* Docs Update

* Missing Import

* More Elements

* Docs Fix

* Fix ItemType

* Revert Misc Changed Files

* Source Retainability

* Update EquippableComponents.sk

* Update ExprEquippableComponent.java

* Requested Changes

* Update Wrapper

* ComponentUtils

* Docs Update

* Update ExprSecBlankEquipComp.java

* Merge dev/feature

* Requested Changes

* Update src/main/java/org/skriptlang/skript/bukkit/itemcomponents/equippable/elements/ExprEquipCompModel.java

Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>

* Pickles Changes - Part 20

* Update CondEquipCompShearable.java
erenkarakal pushed a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
@Absolutionism @erenkarakal
Equippable components (SkriptLang#7194)
f7cd926 
* Starter Commit

* PR ready

* remove "runtime"

* Changes

* Update

* Update

* Overhaul

* Update CondEquipCompInteract.java

* Requested Changes

* Partial Changes

* Update EquippableComponents.sk

* revert

* Record Usage

* Partial Changes

* More Changes

* Changes

* Requested Changes

* Update EquippableComponents.sk

* Update EquippableComponents.sk

* Adooblus Changes

* Update EquippableExperiment.java

* Update Experiment Class  Name

* Requested Changes

* Cloneable Changes

* Update EquippableModule.java

* Update ItemComponentModule.java

* Partial Update

Experiencing some issues, need to see if incorrect merge

* Docs Update

* Missing Import

* More Elements

* Docs Fix

* Fix ItemType

* Revert Misc Changed Files

* Source Retainability

* Update EquippableComponents.sk

* Update ExprEquippableComponent.java

* Requested Changes

* Update Wrapper

* ComponentUtils

* Docs Update

* Update ExprSecBlankEquipComp.java

* Merge dev/feature

* Requested Changes

* Update src/main/java/org/skriptlang/skript/bukkit/itemcomponents/equippable/elements/ExprEquipCompModel.java

Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>

* Pickles Changes - Part 20

* Update CondEquipCompShearable.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@Moderocky Moderocky Moderocky approved these changes

@APickledWalrus APickledWalrus APickledWalrus approved these changes

@UnderscoreTud UnderscoreTud Awaiting requested review from UnderscoreTud UnderscoreTud is a code owner automatically assigned from SkriptLang/core-developers

@Fusezion Fusezion Awaiting requested review from Fusezion

@Efnilite Efnilite Awaiting requested review from Efnilite

+1 more reviewer

@EquipableMC EquipableMC EquipableMC approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature Pull request adding a new feature. needs reviews A PR that needs additional reviews

Projects

No open projects
2.13 Releases
Status: Done - Released

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Absolutionism @sovdeeth @Moderocky @APickledWalrus @EquipableMC @Fusezion @Efnilite @erenkarakal