Update lastMessageAt in markLastMessage by halter73 · Pull Request #4544 · SignalR/SignalR

halter73 · 2021-03-18T22:03:38Z

I'm hoping this fixes #4536.

markLastMessage should still run frequently enough to keep lastMessageAt up-to-date despite chrome's new timer throttling because markLastMessage called by "network response handlers". This means we have to effectively disable our lastMessageAt checking logic if keep-alives are disabled.

BrennanConroy

Looks good, but lets wait for some customer feedback, or until we can test it ourselves.

If there is no keep alive configured, we cannot assume that timer callbacks will run frequently enough to keep lastActiveAt updated. #4536

halter73 · 2021-03-31T19:21:07Z

I'm going to merge this so people can try out Microsoft.AspNet.SignalR.JS version 2.4.2-preview2-* from the https://pkgs.dev.azure.com/dnceng/public/_packaging/myget-legacy/nuget/v3/index.json NuGet feed once it makes it through our CI pipeline.

I ran the build locally and it passed. If there are any issues I'll submit a follow up PR.

jahmai-ca · 2021-04-01T04:23:29Z

Great work and really hope this fixes Chrome reconnecting SignalR over and over. Is there a preview for AspNetCore 3.1?

BrennanConroy · 2021-04-01T16:35:43Z

ASP.NET Core 3.1 has been out for over a year. Also, this repo is for ASP.NET SignalR which is unrelated to ASP.NET Core.

If you're looking to try out the recent changes to the ASP.NET SignalR JavaScript client, you can use

feed: https://pkgs.dev.azure.com/dnceng/public/_packaging/myget-legacy/nuget/v3/index.json
package: Microsoft.AspNet.SignalR.JS
version: 2.4.2-preview2-20210331-01

jahmai-ca · 2021-04-02T01:21:40Z

Hi Brennan,

Sorry I confused this repo for aspnet/SignalR (EDIT: dotnet/aspnetcore), as #4536 describes an identical issue that we're seeing in the AspNetCore version of SignalR.

Didn't mean to offend.

Cheers.

halter73 · 2021-04-05T18:46:34Z

@nitzzzu I see you've deleted the following comment

I've tested 2.4.2-preview2 in my notification service and it does not seem to solve the issue. The client still gets disconnected when idle.

Does this mean 2.4.2-preview2 is working for you?

nitzzzu · 2021-04-05T20:07:08Z

@halter73 yes. I've just used the jquery. signalr.js on client side while keeping an older version on the server side and it seems to work fine

campersau · 2021-04-09T09:16:55Z

src/Microsoft.AspNet.SignalR.JS/jquery.signalR.transports.common.js

+            // run frequently enough to keep lastActiveAt updated.
+            // https://github.com/SignalR/SignalR/issues/4536
+            if (!connection._.keepAliveData.activated ||
+                new Date().getTime() - connection._.lastActiveAt < connection.reconnectWindow) {


What about using a "forward only" time like performance.now() which does not depend on the system clock which might change with timezones / NTP / manually?

MukeshJ2506 · 2021-04-13T04:11:14Z

Hi from where can i install 2.4.2 version with this fix? i cant see the npm library updated. Apology for my lack of insight here

wbeeftink · 2021-04-13T09:20:49Z

Hi from where can i install 2.4.2 version with this fix? i cant see the npm library updated. Apology for my lack of insight here

Hi @MukeshJ2506, what worked for me was this:

Download NuGetPackageExplorer
Copy the feed URL from this comment
Open the feed in package explorer
Search for SignalR and download the 2.4.2. preview version from there
This will give you a NuGet package that contains the .js files you can extract

I don't usually work with NuGet packages, so perhaps there are much easier ways ;-)

MukeshJ2506 · 2021-04-13T13:39:22Z

Hi from where can i install 2.4.2 version with this fix? i cant see the npm library updated. Apology for my lack of insight here

Hi @MukeshJ2506, what worked for me was this:
1. Download [NuGetPackageExplorer](https://github.com/NuGetPackageExplorer/NuGetPackageExplorer)

2. Copy the feed URL from [this comment](https://github.com/SignalR/SignalR/pull/4544#issuecomment-812028464)

3. Open the feed in package explorer

4. Search for SignalR and download the 2.4.2. preview version from there

5. This will give you a NuGet package that contains the .js files you can extract
I don't usually work with NuGet packages, so perhaps there are much easier ways ;-)

@wbeeftink Appreciate your response. thank you 😃

BrennanConroy approved these changes Mar 26, 2021

View reviewed changes

This was referenced Mar 30, 2021

[SignalR TS] Set keep alive timer in receive loop dotnet/aspnetcore#31300

Merged

Chrome terminates WebSocket conenction #4536

Closed

halter73 added 4 commits March 31, 2021 12:04

Update lastMessageAt in markLastMessage

3e9d0b8

Always verifyLastActive if keep-alive messages are disabled

606a935

If there is no keep alive configured, we cannot assume that timer callbacks will run frequently enough to keep lastActiveAt updated. #4536

Don't start heartbeat if it won't be checked

755f39f

bump to preview2

c5d55a5

halter73 force-pushed the halter73/4536 branch from 1bf1589 to c5d55a5 Compare March 31, 2021 19:09

halter73 merged commit f0b5684 into main Mar 31, 2021

halter73 deleted the halter73/4536 branch March 31, 2021 19:21

WayneHiller mentioned this pull request Apr 8, 2021

SignalR connection gets terminated after 5 minutes in Chrome dotnet/aspnetcore#31079

Closed

campersau reviewed Apr 9, 2021

View reviewed changes

halter73 added a commit that referenced this pull request Apr 23, 2021

Fix verifyLastActive tests broken by #4544

e862577

halter73 mentioned this pull request Apr 23, 2021

Fix verifyLastActive tests broken by Chrome timer throttling fix #4553

Merged

halter73 added a commit that referenced this pull request Apr 29, 2021

Fix verifyLastActive tests broken by #4544 (#4553)

ea513b5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update lastMessageAt in markLastMessage#4544

Update lastMessageAt in markLastMessage#4544
halter73 merged 4 commits intomainfrom
halter73/4536

halter73 commented Mar 18, 2021

Uh oh!

BrennanConroy left a comment

Uh oh!

halter73 commented Mar 31, 2021

Uh oh!

jahmai-ca commented Apr 1, 2021

Uh oh!

BrennanConroy commented Apr 1, 2021

Uh oh!

jahmai-ca commented Apr 2, 2021 •

edited

Loading

Uh oh!

halter73 commented Apr 5, 2021

Uh oh!

nitzzzu commented Apr 5, 2021 •

edited

Loading

Uh oh!

campersau Apr 9, 2021

Uh oh!

MukeshJ2506 commented Apr 13, 2021

Uh oh!

wbeeftink commented Apr 13, 2021

Uh oh!

MukeshJ2506 commented Apr 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

halter73 commented Mar 18, 2021

Uh oh!

BrennanConroy left a comment

Choose a reason for hiding this comment

Uh oh!

halter73 commented Mar 31, 2021

Uh oh!

jahmai-ca commented Apr 1, 2021

Uh oh!

BrennanConroy commented Apr 1, 2021

Uh oh!

jahmai-ca commented Apr 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

halter73 commented Apr 5, 2021

Uh oh!

nitzzzu commented Apr 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

campersau Apr 9, 2021

Choose a reason for hiding this comment

Uh oh!

MukeshJ2506 commented Apr 13, 2021

Uh oh!

wbeeftink commented Apr 13, 2021

Uh oh!

MukeshJ2506 commented Apr 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jahmai-ca commented Apr 2, 2021 •

edited

Loading

nitzzzu commented Apr 5, 2021 •

edited

Loading