Redshifted motion handling#57

Merged

attipaci merged 5 commits into

redshifted-objects

Aug 16, 2024

attipaci commented Aug 12, 2024

Collaborator

So far, sidereal (i.e. catalog) sources were defined with parameters typical for stars in our Galaxy. As such, motion was parametrized by radial velocity (in line of sight) , as well as proper motion. And, as a result, NOVAS did not offer proper support for handling distant quasars or galaxies, where line-of-sight motion is more typically parameterized with a redshift (z) instead.

Thus we now add:

novas_z2v() to convert redshift values (z) to an equivalent radial velocity (in km/s).
novas_v2z() to convert radial velocity values(in km/s) to an equivalent redshift (z).
make_redshifted_object() to simplify the initialization of distant sources parameterized by redshift. It will set proper motion and parallax to zero, and initialized the source catalog to EXT to indicate an extragalactic source. (The user may then override the initial values, if necessary).

attipaci added the enhancement label

attipaci added this to the 1.2.0 milestone

attipaci self-assigned this

attipaci added 5 commits

August 12, 2024 11:56


          A corrected version ref in README

8c98705


          Another reference to API documentation in README

5aa5d6a


          Small edits to README

b1e504a


          Shoft release schedule up to imporve Fedora package integration

4c1c5ba


          Add redshift handling routines.

2435f0c

attipaci force-pushed the redshifted-objects branch from 6cd44cd to 2435f0c Compare

August 12, 2024 10:13

codecov Bot commented Aug 12, 2024 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v1.2.0@2dafcbb). Learn more about missing BASE report.

Additional details and impacted files

@@            Coverage Diff            @@
##             v1.2.0      #57   +/-   ##
=========================================
  Coverage          ?   99.64%           
=========================================
  Files             ?        6           
  Lines             ?     2802           
  Branches          ?      539           
=========================================
  Hits              ?     2792           
  Misses            ?        0           
  Partials          ?       10

Flag	Coverage Δ
unittests	`99.64% <100.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
src/novas.c	`99.58% <100.00%> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dafcbb...2435f0c. Read the comment docs.

attipaci marked this pull request as ready for review

August 16, 2024 09:42

attipaci merged commit a2c83ef into v1.2.0

attipaci deleted the redshifted-objects branch

August 16, 2024 09:43

attipaci added a commit that referenced this pull request


          Redshifted motion handling (#57)

3dd2506

* A corrected version ref in README

* Another reference to API documentation in README

* Small edits to README

* Shoft release schedule up to imporve Fedora package integration

* Add redshift handling routines.

attipaci added a commit that referenced this pull request


          Redshifted motion handling (#57)

119f944

* A corrected version ref in README

* Another reference to API documentation in README

* Small edits to README

* Shoft release schedule up to imporve Fedora package integration

* Add redshift handling routines.

attipaci added a commit that referenced this pull request


          Redshifted motion handling (#57)

e0662ea

* A corrected version ref in README

* Another reference to API documentation in README

* Small edits to README

* Shoft release schedule up to imporve Fedora package integration

* Add redshift handling routines.

attipaci added a commit that referenced this pull request


          Redshifted motion handling (#57)

adaf982

* A corrected version ref in README

* Another reference to API documentation in README

* Small edits to README

* Shoft release schedule up to imporve Fedora package integration

* Add redshift handling routines.

attipaci added a commit that referenced this pull request


          Redshifted motion handling (#57)

8351d10

* A corrected version ref in README

* Another reference to API documentation in README

* Small edits to README

* Shoft release schedule up to imporve Fedora package integration

* Add redshift handling routines.

attipaci added a commit that referenced this pull request


          Redshifted motion handling (#57)

8022f38

* A corrected version ref in README

* Another reference to API documentation in README

* Small edits to README

* Shoft release schedule up to imporve Fedora package integration

* Add redshift handling routines.

attipaci added a commit that referenced this pull request


          Redshifted motion handling (#57)

fc783e0

* A corrected version ref in README

* Another reference to API documentation in README

* Small edits to README

* Shoft release schedule up to imporve Fedora package integration

* Add redshift handling routines.

attipaci added a commit that referenced this pull request


          Redshifted motion handling (#57)

7e4f5ad

* A corrected version ref in README

* Another reference to API documentation in README

* Small edits to README

* Shoft release schedule up to imporve Fedora package integration

* Add redshift handling routines.

attipaci added a commit that referenced this pull request


          Redshifted motion handling (#57)

369d569

* A corrected version ref in README

* Another reference to API documentation in README

* Small edits to README

* Shoft release schedule up to imporve Fedora package integration

* Add redshift handling routines.

attipaci added a commit that referenced this pull request


          Redshifted motion handling (#57)

52758ac

* A corrected version ref in README

* Another reference to API documentation in README

* Small edits to README

* Shoft release schedule up to imporve Fedora package integration

* Add redshift handling routines.

attipaci added a commit that referenced this pull request


          Redshift utilities (#58)

f92a4e7

* Redshifted motion handling (#57)

* A corrected version ref in README

* Another reference to API documentation in README

* Small edits to README

* Shoft release schedule up to imporve Fedora package integration

* Add redshift handling routines.

* Add functions to apply/adjust gravitational redshift for radial velocities.

* Tweaks and redshift_add() function

* Tweaks

* Added novas_z_inv()

* Further tweaks

* small edits to error handling

* various fixes

* Small arithmetic simplification

* Doxygen edits

* Test cases for redshift functions

* Split out util.c

* test/Makefile: Fix bad rebase

* merge util.c -> super.c

* super.c: Delete empty lines

attipaci added a commit that referenced this pull request


          Redshifted motion handling (#57)

568745a

* A corrected version ref in README

* Another reference to API documentation in README

* Small edits to README

* Shoft release schedule up to imporve Fedora package integration

* Add redshift handling routines.

attipaci added a commit that referenced this pull request


          Redshift utilities (#58)

b17c215

* Redshifted motion handling (#57)

* A corrected version ref in README

* Another reference to API documentation in README

* Small edits to README

* Shoft release schedule up to imporve Fedora package integration

* Add redshift handling routines.

* Add functions to apply/adjust gravitational redshift for radial velocities.

* Tweaks and redshift_add() function

* Tweaks

* Added novas_z_inv()

* Further tweaks

* small edits to error handling

* various fixes

* Small arithmetic simplification

* Doxygen edits

* Test cases for redshift functions

* Split out util.c

* test/Makefile: Fix bad rebase

* merge util.c -> super.c

* super.c: Delete empty lines

attipaci added a commit that referenced this pull request


          Redshifted motion handling (#57)

6f2ee32

* A corrected version ref in README

* Another reference to API documentation in README

* Small edits to README

* Shoft release schedule up to imporve Fedora package integration

* Add redshift handling routines.

attipaci added a commit that referenced this pull request


          Redshift utilities (#58)

27a5743

* Redshifted motion handling (#57)

* A corrected version ref in README

* Another reference to API documentation in README

* Small edits to README

* Shoft release schedule up to imporve Fedora package integration

* Add redshift handling routines.

* Add functions to apply/adjust gravitational redshift for radial velocities.

* Tweaks and redshift_add() function

* Tweaks

* Added novas_z_inv()

* Further tweaks

* small edits to error handling

* various fixes

* Small arithmetic simplification

* Doxygen edits

* Test cases for redshift functions

* Split out util.c

* test/Makefile: Fix bad rebase

* merge util.c -> super.c

* super.c: Delete empty lines

attipaci added a commit that referenced this pull request


          Redshifted motion handling (#57)

6bc9a02

* A corrected version ref in README

* Another reference to API documentation in README

* Small edits to README

* Shoft release schedule up to imporve Fedora package integration

* Add redshift handling routines.

attipaci added a commit that referenced this pull request


          Redshift utilities (#58)

7673cfb

* Redshifted motion handling (#57)

* A corrected version ref in README

* Another reference to API documentation in README

* Small edits to README

* Shoft release schedule up to imporve Fedora package integration

* Add redshift handling routines.

* Add functions to apply/adjust gravitational redshift for radial velocities.

* Tweaks and redshift_add() function

* Tweaks

* Added novas_z_inv()

* Further tweaks

* small edits to error handling

* various fixes

* Small arithmetic simplification

* Doxygen edits

* Test cases for redshift functions

* Split out util.c

* test/Makefile: Fix bad rebase

* merge util.c -> super.c

* super.c: Delete empty lines

attipaci added a commit that referenced this pull request


          Redshifted motion handling (#57)

4f08a74

* A corrected version ref in README

* Another reference to API documentation in README

* Small edits to README

* Shoft release schedule up to imporve Fedora package integration

* Add redshift handling routines.

attipaci added a commit that referenced this pull request


          Redshift utilities (#58)

9fe78a5

* Redshifted motion handling (#57)

* A corrected version ref in README

* Another reference to API documentation in README

* Small edits to README

* Shoft release schedule up to imporve Fedora package integration

* Add redshift handling routines.

* Add functions to apply/adjust gravitational redshift for radial velocities.

* Tweaks and redshift_add() function

* Tweaks

* Added novas_z_inv()

* Further tweaks

* small edits to error handling

* various fixes

* Small arithmetic simplification

* Doxygen edits

* Test cases for redshift functions

* Split out util.c

* test/Makefile: Fix bad rebase

* merge util.c -> super.c

* super.c: Delete empty lines

attipaci added a commit that referenced this pull request


          Redshifted motion handling (#57)

1cf0bbf

* A corrected version ref in README

* Another reference to API documentation in README

* Small edits to README

* Shoft release schedule up to imporve Fedora package integration

* Add redshift handling routines.

attipaci added a commit that referenced this pull request


          Redshift utilities (#58)

ee20d52

* Redshifted motion handling (#57)

* A corrected version ref in README

* Another reference to API documentation in README

* Small edits to README

* Shoft release schedule up to imporve Fedora package integration

* Add redshift handling routines.

* Add functions to apply/adjust gravitational redshift for radial velocities.

* Tweaks and redshift_add() function

* Tweaks

* Added novas_z_inv()

* Further tweaks

* small edits to error handling

* various fixes

* Small arithmetic simplification

* Doxygen edits

* Test cases for redshift functions

* Split out util.c

* test/Makefile: Fix bad rebase

* merge util.c -> super.c

* super.c: Delete empty lines

attipaci added a commit that referenced this pull request


          Redshifted motion handling (#57)

dc51799

* A corrected version ref in README

* Another reference to API documentation in README

* Small edits to README

* Shoft release schedule up to imporve Fedora package integration

* Add redshift handling routines.

attipaci added a commit that referenced this pull request


          Redshift utilities (#58)

4716e2d

* Redshifted motion handling (#57)

* A corrected version ref in README

* Another reference to API documentation in README

* Small edits to README

* Shoft release schedule up to imporve Fedora package integration

* Add redshift handling routines.

* Add functions to apply/adjust gravitational redshift for radial velocities.

* Tweaks and redshift_add() function

* Tweaks

* Added novas_z_inv()

* Further tweaks

* small edits to error handling

* various fixes

* Small arithmetic simplification

* Doxygen edits

* Test cases for redshift functions

* Split out util.c

* test/Makefile: Fix bad rebase

* merge util.c -> super.c

* super.c: Delete empty lines

attipaci added a commit that referenced this pull request


          Redshifted motion handling (#57)

46810f1

* A corrected version ref in README

* Another reference to API documentation in README

* Small edits to README

* Shoft release schedule up to imporve Fedora package integration

* Add redshift handling routines.

attipaci added a commit that referenced this pull request


          Redshift utilities (#58)

e4e12f3

* Redshifted motion handling (#57)

* A corrected version ref in README

* Another reference to API documentation in README

* Small edits to README

* Shoft release schedule up to imporve Fedora package integration

* Add redshift handling routines.

* Add functions to apply/adjust gravitational redshift for radial velocities.

* Tweaks and redshift_add() function

* Tweaks

* Added novas_z_inv()

* Further tweaks

* small edits to error handling

* various fixes

* Small arithmetic simplification

* Doxygen edits

* Test cases for redshift functions

* Split out util.c

* test/Makefile: Fix bad rebase

* merge util.c -> super.c

* super.c: Delete empty lines

attipaci added a commit that referenced this pull request


          Redshifted motion handling (#57)

* A corrected version ref in README

* Another reference to API documentation in README

* Small edits to README

* Shoft release schedule up to imporve Fedora package integration

* Add redshift handling routines.

attipaci added a commit that referenced this pull request


          Redshift utilities (#58)

42accb2

* Redshifted motion handling (#57)

* A corrected version ref in README

* Another reference to API documentation in README

* Small edits to README

* Shoft release schedule up to imporve Fedora package integration

* Add redshift handling routines.

* Add functions to apply/adjust gravitational redshift for radial velocities.

* Tweaks and redshift_add() function

* Tweaks

* Added novas_z_inv()

* Further tweaks

* small edits to error handling

* various fixes

* Small arithmetic simplification

* Doxygen edits

* Test cases for redshift functions

* Split out util.c

* test/Makefile: Fix bad rebase

* merge util.c -> super.c

* super.c: Delete empty lines

attipaci added a commit that referenced this pull request


          Redshifted motion handling (#57)

cb68116

* A corrected version ref in README

* Another reference to API documentation in README

* Small edits to README

* Shoft release schedule up to imporve Fedora package integration

* Add redshift handling routines.

attipaci added a commit that referenced this pull request


          Redshift utilities (#58)

3c9cdd1

* Redshifted motion handling (#57)

* A corrected version ref in README

* Another reference to API documentation in README

* Small edits to README

* Shoft release schedule up to imporve Fedora package integration

* Add redshift handling routines.

* Add functions to apply/adjust gravitational redshift for radial velocities.

* Tweaks and redshift_add() function

* Tweaks

* Added novas_z_inv()

* Further tweaks

* small edits to error handling

* various fixes

* Small arithmetic simplification

* Doxygen edits

* Test cases for redshift functions

* Split out util.c

* test/Makefile: Fix bad rebase

* merge util.c -> super.c

* super.c: Delete empty lines

attipaci mentioned this pull request

Redshift utilities #78

Merged

attipaci added a commit that referenced this pull request


          Redshifted motion handling (#57)

70a9fb4

* A corrected version ref in README

* Another reference to API documentation in README

* Small edits to README

* Shoft release schedule up to imporve Fedora package integration

* Add redshift handling routines.

attipaci added a commit that referenced this pull request


          Redshift utilities (#58)

9ccb8d3

* Redshifted motion handling (#57)

* A corrected version ref in README

* Another reference to API documentation in README

* Small edits to README

* Shoft release schedule up to imporve Fedora package integration

* Add redshift handling routines.

* Add functions to apply/adjust gravitational redshift for radial velocities.

* Tweaks and redshift_add() function

* Tweaks

* Added novas_z_inv()

* Further tweaks

* small edits to error handling

* various fixes

* Small arithmetic simplification

* Doxygen edits

* Test cases for redshift functions

* Split out util.c

* test/Makefile: Fix bad rebase

* merge util.c -> super.c

* super.c: Delete empty lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels