Skip to content

New site/observer initializers with default mean weather parameters.#245

Merged
attipaci merged 4 commits into
mainfrom
site-init
Sep 13, 2025
Merged

New site/observer initializers with default mean weather parameters.#245
attipaci merged 4 commits into
mainfrom
site-init

Conversation

@attipaci

@attipaci attipaci commented Sep 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Added

int make_itrf_observer(double latitude, double longitude, double height, observer *obs);

int make_gps_observer(double latitude, double longitude, double height, observer *obs);

int make_observer_at_site(const on_surface *restrict site, observer *restrict obs);

int make_itrf_site(double latitude, double longitude, double height, on_surface *site);

int make_gps_site(double latitude, double longitude, double height, on_surface *site);

int make_xyz_site(const double *restrict xyz, on_surface *restrict site);

int novas_set_default_weather(on_surface *site);

Deprecated

  • make_on_surface()
  • make_observer_on_surface()
  • make_observer()

@attipaci attipaci added this to the 1.5.0 milestone Sep 12, 2025
@attipaci attipaci self-assigned this Sep 12, 2025
@attipaci attipaci added the enhancement New feature or request label Sep 12, 2025
@codecov

codecov Bot commented Sep 12, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.89%. Comparing base (18b55fe) to head (fd91249).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #245   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files          24       24           
  Lines        4561     4605   +44     
  Branches      906      912    +6     
=======================================
+ Hits         4556     4600   +44     
  Partials        5        5
Flag Coverage Δ
unittests 99.89% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/earth.c 100.00% <ø> (ø)
src/equinox.c 100.00% <ø> (ø)
src/frames.c 99.85% <ø> (ø)
src/grav.c 100.00% <ø> (ø)
src/observer.c 100.00% <100.00%> (ø)
src/orbital.c 100.00% <ø> (ø)
src/planets.c 99.23% <ø> (ø)
src/refract.c 100.00% <100.00%> (ø)
src/spectral.c 100.00% <ø> (ø)
src/target.c 100.00% <ø> (ø)
... and 2 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3da62bf...fd91249. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@attipaci attipaci force-pushed the site-init branch 11 times, most recently from bce04ec to 332b259 Compare September 13, 2025 09:14
@attipaci attipaci force-pushed the site-init branch 2 times, most recently from 686012a to 25f6577 Compare September 13, 2025 10:48
@attipaci attipaci force-pushed the site-init branch 4 times, most recently from a12d23c to 9ef4066 Compare September 13, 2025 11:19
@attipaci attipaci force-pushed the site-init branch 4 times, most recently from 9f9a538 to 6c23ec6 Compare September 13, 2025 18:15
@attipaci attipaci marked this pull request as ready for review September 13, 2025 18:23
@attipaci attipaci merged commit e067fb2 into main Sep 13, 2025
27 checks passed
@attipaci attipaci deleted the site-init branch September 13, 2025 18:25
attipaci added a commit that referenced this pull request Sep 13, 2025
@attipaci
chnagelog update for PR #245
6e3b530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@attipaci attipaci

Labels

enhancement New feature or request

Projects

None yet

Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

1 participant

@attipaci