Skip to content

Deprecate cio_basis()#214

Merged
attipaci merged 1 commit into
nextfrom
gcrs_cirs
Aug 23, 2025
Merged

Deprecate cio_basis()#214
attipaci merged 1 commit into
nextfrom
gcrs_cirs

Conversation

@attipaci

Copy link
Copy Markdown
Collaborator

Deprecate cio_basis(). It is no longer used internally. Instead, gcrs_to_cirs() / cirs_to_gcrs() use more transparent ways of transforming, and frames are also initialized somewhat faster without it.

@attipaci attipaci added this to the 1.5.0 milestone Aug 23, 2025
@attipaci attipaci self-assigned this Aug 23, 2025
@attipaci attipaci added the enhancement New feature or request label Aug 23, 2025
@codecov

codecov Bot commented Aug 23, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.88%. Comparing base (7355217) to head (9a94cce).
⚠️ Report is 3 commits behind head on next.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #214      +/-   ##
==========================================
- Coverage   99.91%   99.88%   -0.03%     
==========================================
  Files          23       23              
  Lines        4500     4479      -21     
  Branches      841      833       -8     
==========================================
- Hits         4496     4474      -22     
- Partials        4        5       +1     
Flag Coverage Δ
unittests 99.88% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/cio.c 98.22% <100.00%> (-0.60%) ⬇️
src/frames.c 99.73% <100.00%> (+<0.01%) ⬆️
src/system.c 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7355217...9a94cce. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@attipaci attipaci merged commit 5f51927 into next Aug 23, 2025
14 checks passed
@attipaci attipaci deleted the gcrs_cirs branch August 23, 2025 09:45
attipaci added a commit that referenced this pull request Aug 23, 2025
attipaci added a commit that referenced this pull request Aug 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant