Wean off CIO locator file internally.#208
Merged
Merged
Conversation
38b25f4 to
d6faf98
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #208 +/- ##
==========================================
- Coverage 99.91% 99.91% -0.01%
==========================================
Files 23 23
Lines 4553 4550 -3
Branches 840 843 +3
==========================================
- Hits 4549 4546 -3
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
3244bdb to
0ff887d
Compare
…to be needed otherwise.
0ff887d to
8d123b5
Compare
attipaci
added a commit
that referenced
this pull request
Aug 23, 2025
attipaci
added a commit
that referenced
this pull request
Aug 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CIO locator file (
CIO_RA.TXTorcio_ra.bin) was always entirely optional. While it offers a minor performance boost (provided the required values are already cached), there is really no reason for the library to rely on this external data dependence. Not to mention that the locator table was prepared with the now obsoleted original IAU2000A precession/nutation model (hence it is not accurate at the μas level decades away from J2000). It is better for the library to remain fully self-consistent, and self-contained. Thus, we'll stop using the CIO locator data internally in the library.Users may continue to access the CIO locator file if needed for legacy applications if need be.