Skip to content

Fixes to Earth orientation (polar wobble) corrections#182

Merged
attipaci merged 1 commit into
mainfrom
dup-wobble
May 9, 2025
Merged

Fixes to Earth orientation (polar wobble) corrections#182
attipaci merged 1 commit into
mainfrom
dup-wobble

Conversation

@attipaci

@attipaci attipaci commented May 9, 2025

Copy link
Copy Markdown
Collaborator
  • Missing wobble corrections in frame-based approach (PEF <--> ITRS).
  • Old-style (now disfavored) wobble corrections via cel_pole() were not applied to true obliquity and the equation of the equinoxes in e_tilt().
  • Deprecate cel_pole() function and the PSI_COR / EPS_COR variables, which supported the old-style (now disfavored) way of dealing with Earth orientations parameters.

@attipaci attipaci added this to the 1.4.0 milestone May 9, 2025
@attipaci attipaci self-assigned this May 9, 2025
@attipaci attipaci added the enhancement New feature or request label May 9, 2025
@codecov

codecov Bot commented May 9, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.91%. Comparing base (038cca9) to head (946fa81).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #182   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files          23       23           
  Lines        4516     4519    +3     
  Branches      840      840           
=======================================
+ Hits         4512     4515    +3     
  Partials        4        4           
Flag Coverage Δ
unittests 99.91% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/earth.c 100.00% <100.00%> (ø)
src/frames.c 99.71% <100.00%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 038cca9...946fa81. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@attipaci attipaci force-pushed the dup-wobble branch 2 times, most recently from a1fb9ed to dcfd74b Compare May 9, 2025 18:35
@attipaci attipaci marked this pull request as ready for review May 9, 2025 18:36
@attipaci attipaci linked an issue May 9, 2025 that may be closed by this pull request
@attipaci attipaci added the bug Something isn't working label May 9, 2025
@attipaci attipaci linked an issue May 9, 2025 that may be closed by this pull request
@attipaci attipaci force-pushed the dup-wobble branch 3 times, most recently from 26d2f33 to f4507e3 Compare May 9, 2025 19:46
@attipaci attipaci changed the title Avoid duplicate wobble correction when using frames and cel_pole(). Fixes to Earth orientation (polar wobble) corrections May 9, 2025
@attipaci attipaci merged commit 32af078 into main May 9, 2025
@attipaci attipaci deleted the dup-wobble branch May 9, 2025 19:58
attipaci added a commit that referenced this pull request May 11, 2025
@attipaci

Copy link
Copy Markdown
Collaborator Author

Post-merge wobble() units correction on main at a2fb5f9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing wobble corrections in frame-based calculations Incomplete legacy polar wobble correction

1 participant