Add approximate orbital models for major planets, EMB, and Moon.#176
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
========================================
Coverage 99.90% 99.91%
========================================
Files 22 23 +1
Lines 4335 4494 +159
Branches 814 836 +22
========================================
+ Hits 4331 4490 +159
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
2a31370 to
d0d4637
Compare
19934db to
261fb7f
Compare
a100650 to
0da6a33
Compare
attipaci
added a commit
that referenced
this pull request
May 9, 2025
attipaci
added a commit
that referenced
this pull request
May 9, 2025
attipaci
added a commit
that referenced
this pull request
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding:
make_planet_orbit()to generate Keplerian orbital elements for the major planets (sans Earth), and the Earth-Moon Barycenter (EMB), based on Standish & Williams 1992. In most cases such orbitals can provide arcmin-level precisions, especially for current dates.make_moon_orbit()to generate geocentric Keplerian orbital elements for the Moon using the Chapront et al. 2002 model.novas_approx_heliocentric()to calculate approximate heliocentric ICRS positions for the major planets (including Earth), and Moon and the Earth-Moon Barycenter, using the orbital models mentioned above.novas_approx_sky_pos()to calculate approximate observable positions and velocities for the major planets (including Earth), and Moon and the Earth-Moon Barycenter, using the orbital models mentioned above.novas_moon_phase()andnovas_next_moon_phase()to calculate the Moon's apparent phase or the date/time when it reaches a specific phse, respectively, suing the Keplerian orbitals for the E-M Barycenter by Standish & Williams 1992, and the geocentric orbitals of the Moon by Chapront et al. 2002.novas_orbital_native_posvel()to calculate orbital positions in the native system, in which the orbital is defined (e.g. ecliptic coordinates for planetary orbits).