Skip to content

Add novas_parse_hours() / novas_parse_degrees()#134

Merged
attipaci merged 1 commit into
mainfrom
parse-degrees-hours
Mar 2, 2025
Merged

Add novas_parse_hours() / novas_parse_degrees()#134
attipaci merged 1 commit into
mainfrom
parse-degrees-hours

Conversation

@attipaci

@attipaci attipaci commented Mar 2, 2025

Copy link
Copy Markdown
Collaborator
  • Parse string values either as decimal or as HMS/DMS.
  • Walk back on parsing extended ASCII DMS symbols. scanf() does not handle character count with these properly, and wscanf() is not as portable.
  • Split parsing function into separate module (parse.c) to alleviate bloating of super.c

@attipaci attipaci added the enhancement New feature or request label Mar 2, 2025
@attipaci attipaci added this to the 1.3.0 milestone Mar 2, 2025
@attipaci attipaci self-assigned this Mar 2, 2025
@codecov

codecov Bot commented Mar 2, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.55%. Comparing base (d90f6bc) to head (1759b6d).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #134   +/-   ##
=======================================
  Coverage   99.54%   99.55%           
=======================================
  Files           8        9    +1     
  Lines        3982     4036   +54     
  Branches      721      735   +14     
=======================================
+ Hits         3964     4018   +54     
  Misses          4        4           
  Partials       14       14           
Flag Coverage Δ
unittests 99.55% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/parse.c 100.00% <100.00%> (ø)
src/super.c 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89e17a5...1759b6d. Read the comment docs.

@attipaci attipaci force-pushed the parse-degrees-hours branch 10 times, most recently from fc5669f to cc8d7a9 Compare March 2, 2025 20:49
@attipaci attipaci force-pushed the parse-degrees-hours branch from cc8d7a9 to 1759b6d Compare March 2, 2025 20:50
@attipaci attipaci marked this pull request as ready for review March 2, 2025 20:52
@attipaci attipaci merged commit 55f87aa into main Mar 2, 2025
@attipaci attipaci deleted the parse-degrees-hours branch March 2, 2025 20:56
attipaci added a commit that referenced this pull request Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant