Skip to content

Negative years to indicate B.C. dates consistently#121

Merged
attipaci merged 1 commit into
mainfrom
bc-dates
Jan 28, 2025
Merged

Negative years to indicate B.C. dates consistently#121
attipaci merged 1 commit into
mainfrom
bc-dates

Conversation

@attipaci

@attipaci attipaci commented Jan 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

REVERTED. The Astronomical and ISO 8601 standard is to indicate 1 B.C. as year 0 (not -1).

Affects:

  • julian_date()
  • cal_date()
  • novas_parse_date_format() / novas_parse_date()
  • novas_timestamp() / novas_iso_timestamp()

Adds:

  • cal_date2(), which works like cal_date() but takes int * pointers intead of short *.

@codecov

codecov Bot commented Jan 28, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.72%. Comparing base (94cb726) to head (b436b0d).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #121   +/-   ##
=======================================
  Coverage   99.72%   99.72%           
=======================================
  Files           8        8           
  Lines        3597     3607   +10     
  Branches      698      702    +4     
=======================================
+ Hits         3587     3597   +10     
  Misses          1        1           
  Partials        9        9
Flag Coverage Δ
unittests 99.72% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/novas.c 99.57% <100.00%> (+<0.01%) ⬆️
src/timescale.c 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94cb726...b436b0d. Read the comment docs.

@attipaci attipaci force-pushed the bc-dates branch 2 times, most recently from f1e89b4 to ae02245 Compare January 28, 2025 19:47
@attipaci attipaci marked this pull request as ready for review January 28, 2025 19:49
@attipaci attipaci force-pushed the bc-dates branch 3 times, most recently from 3c2cfe3 to c78e1f8 Compare January 28, 2025 19:54
@attipaci attipaci changed the title Negative years to indicate BC dates consistently Negative years to indicate B.C. dates consistently Jan 28, 2025
@attipaci attipaci self-assigned this Jan 28, 2025
@attipaci attipaci added the enhancement New feature or request label Jan 28, 2025
@attipaci attipaci added this to the 1.3.0 milestone Jan 28, 2025
@attipaci attipaci merged commit 92ca836 into main Jan 28, 2025
@attipaci attipaci deleted the bc-dates branch January 28, 2025 20:04
@attipaci attipaci mentioned this pull request Jan 29, 2025
Merged
attipaci added a commit that referenced this pull request Jan 29, 2025
@attipaci
Undo PR #121 -- The astronomical / ISO standard is 1 B.C. = 0.
53f2e6b
attipaci added a commit that referenced this pull request Jan 29, 2025
@attipaci
Undo PR #121 -- The astronomical / ISO standard is 1 B.C. = 0.
4708cad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@attipaci attipaci

Labels

enhancement New feature or request

Projects

None yet

Milestone

1.3.0

Development

Successfully merging this pull request may close these issues.

1 participant

@attipaci