Support DocumentLink request#195
Merged
Merged
Conversation
Morriar
reviewed
Jul 14, 2022
Morriar
reviewed
Jul 14, 2022
777097a to
4d8f6ba
Compare
Member
|
This PR looks almost ready to go for us all to enjoy jumping to gem source from RBIs. Can we please finalize the request documentation? |
This request uses the gem source comments generated by Tapioca to let users quickly jump to the actual source of the definition.
Co-authored-by: Alexandre Terrasa <Morriar@users.noreply.github.com> Co-authored-by: Vinicius Stock <vinistock@users.noreply.github.com> Co-authored-by: Stan Lo <st0012@users.noreply.github.com> Co-authored-by: Maple Ong <wildmaples@users.noreply.github.com> Co-authored-by: Adison Lampert <adisonlampert@users.noreply.github.com> Co-authored-by: Emily Giurleo <egiurleo@users.noreply.github.com>
4d8f6ba to
91fd038
Compare
aeaab14 to
9ec0495
Compare
Morriar
approved these changes
Jul 27, 2022
Co-authored-by: Alexandre Terrasa <583144+Morriar@users.noreply.github.com>
vinistock
pushed a commit
that referenced
this pull request
Aug 12, 2022
Support DocumentLink request
andyw8
pushed a commit
to andyw8/ruby-lsp
that referenced
this pull request
Mar 2, 2024
…sbuild-0.15.5 Bump esbuild from 0.15.3 to 0.15.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This request uses the gem source comments generated by Tapioca to let users quickly jump to the actual source of the definition.
Implementation
Add a new
DocumentLinkrequest to detect# source://PATH_TO_FILE:linecomments and return clickable links if the file exists.Automated Tests
New expectation + integration test cases.
Manual Tests
vscode-ruby-lspextension from the PRbundle exec tapioca gemto make sure we have rbi files that have the new source comments# source://PATH_TO_FILE:linecomments and hover the mouse over one of themJump to PATH_TO_FILE#linein the tooltipDemo