This repository was archived by the owner on Jun 13, 2018. It is now read-only.
Save description for UPS shipment event in message #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
on 💚
Contributor
|
👍 |
Contributor
|
Change looks good! Let's get the build fixed out of band first though. |
a3fbdc9 to
ef4d734
Compare
maartenvg
pushed a commit
that referenced
this pull request
Nov 9, 2017
Save description for UPS shipment event in message
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
For the other carrier adapters, we always save something for the
messageof aShipmentEvent-EventinmessageEventDescriptionevent-descriptioninmessageUPS doesn't do anything, and just gives it a
nilvalue. Rather thannilthe value, we can do what USPS and FedEx do and pass in the event description.This change will keep the carriers consistent with each other.
Changes
Simply store the text in the
'Status/StatusType/Description')node inmessagefor eachShipmentEvent.Testing
Added another unit test in
test/unit/ups_test.rbto verify the existence ofmessagefor each shipment event in a response.@kmcphillips @mdking @RichardBlair @MalazAlamir