This repository was archived by the owner on Aug 30, 2018. It is now read-only.
Conversation
Contributor
|
code looks good, but are these design elements needed to display the forms? |
Contributor
Author
|
To display them in line with the other base styles, yes. They were missed when changing the default form styles in an earlier PR. For example, the forgot password form: Before: After: |
Contributor
Author
|
The above screenshots make more sense when you look at the login form too (which moves the 'forgot password' link below the Sign in button): |
Contributor
Author
|
@mpiotrowicz good to go? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor style updates for customer area forms to ensure they're more unified in design.
cc/ @mpiotrowicz @stevebosworth