proj: Implement simple TX-RX comms#56
Merged
svire-at merged 3 commits intoShiegeChan:devfrom Dec 3, 2025
Merged
Conversation
Create FSK_TX, FSK_RX, rx_demod scripts
11 tasks
svire-at
reviewed
Dec 1, 2025
Comment on lines
+31
to
+35
|
|
||
|
|
||
|
|
||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
Refer to coding style guidelines for adding empty lines in code.
svire-at
reviewed
Dec 1, 2025
|
|
||
| } | ||
|
|
||
| // TWO OPTIONS: SINGLE WAVE --> enable in the loop with delay; CONTINUOUS WAV --> enable in the set up |
Collaborator
There was a problem hiding this comment.
Comment potentially not needed?
svire-at
reviewed
Dec 1, 2025
| // wait for the data and send it | ||
| while(!SensEdu_ADC_GetTransferStatus(adc)); | ||
| SensEdu_ADC_ClearTransferStatus(adc); | ||
| serial_send_array((const uint8_t *) & mic_data, mic_data_size << 1); |
Collaborator
There was a problem hiding this comment.
we should have the reference operator & without 'space' between it and the type or the variable. Refer to previous examples.
svire-at
reviewed
Dec 1, 2025
Comment on lines
+20
to
+21
| data = zeros(1,ITERATIONS); | ||
| time_axis = zeros(1,ITERATIONS); |
svire-at
reviewed
Dec 1, 2025
Comment on lines
+36
to
+43
| % % save measurements | ||
| % if ~exist("Measurements", 'dir') | ||
| % mkdir("Measurements"); | ||
| % end | ||
| % file_name = sprintf('Measurements/%s_%s.mat', "measurements", datetime("now")); | ||
| % file_name = strrep(file_name, ' ', '_'); | ||
| % file_name = strrep(file_name, ':', '-'); | ||
| % save(file_name, "data", "time_axis"); |
Collaborator
There was a problem hiding this comment.
Remove completely if not needed.
svire-at
reviewed
Dec 1, 2025
Collaborator
svire-at
left a comment
There was a problem hiding this comment.
Looks good! In general, the coding style and neatness of the code should be taken care of. I left couple of comments as an example what should be changed.
Comment on lines
+32
to
+33
| .mem_address = (uint16_t*)sine_lut, // TODO | ||
| .mem_size = sine_lut_size, // TODO |
|
|
||
| // Configure the DAC | ||
|
|
||
| #define DAC_SINE_FREQ 33000 // 32kHz |
Collaborator
There was a problem hiding this comment.
Comment doesn't match the actual frequency that is set
Collaborator
Author
|
@svire-at fixed. Please review it again in case it needs another changes. |
svire-at
approved these changes
Dec 3, 2025
fanfare-ff
pushed a commit
that referenced
this pull request
Jan 23, 2026
* feat: Add basic structure for FSK project * feat: Implement simple TX-RX transmission Create FSK_TX, FSK_RX, rx_demod scripts * Fix: coding style (#56) * feat: Add two frequency settings * feat: Implemented loop for bit modulation * feat: TX with two DAC * feat: Create Tx Rx sync with 2 DAC * feat: Encode U symbol successfully * feat: FSK demodulation working * feat: Dynamic LUT implemented * feat: Implement dynamic thresholding Update Algorithm Add Serial Monitor message transmission * feat: Code polished * refactor: Fix styling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the Pull Request fulfils these requirements
Type: Descriptive NameLink related open issue
[TASK] Simple TX-RX Wave Transmission for FSK #50
Provide a short description
Implement simple TX-RX path between two SensEdu boards
Does this PR introduce a breaking change? (What must be changed in other projects/examples due to this PR?)
N/A
Other information (Anything else reviewers should know)
N/A