[Dropdown] Removed deletion of text/value metadata#3879
Closed
mdehoog wants to merge 1 commit intoSemantic-Org:nextfrom
Closed
[Dropdown] Removed deletion of text/value metadata#3879mdehoog wants to merge 1 commit intoSemantic-Org:nextfrom
mdehoog wants to merge 1 commit intoSemantic-Org:nextfrom
Conversation
jlukic
added a commit
that referenced
this pull request
May 15, 2016
Member
|
It looks like the internal issue was that mutation observers were accidentally triggering I've resolved this by refactoring the mutation observers to ignore internal changes. The reason we have to flush data attributes in These values are typically updated when a mutation observer detects the underlying DOM has been rewritten. |
jlukic
added a commit
that referenced
this pull request
May 15, 2016
jlukic
added a commit
that referenced
this pull request
May 15, 2016
Member
|
Fixed in |
Contributor
Author
|
@jlukic thanks so much for following this up 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3622.
Happy to put this behind a flag instead if you think the current behavior should be the default.