Fixes left arrow key in dropdown search input#3596
Conversation
For the case where no item is selected. Because in this case $parentMenu is still something else than $menu.
Member
|
Can you explain what might trigger this issue? |
Member
|
@sanjo Delaying this without a specific test case |
Author
|
Reproduce:
This fix just adds the condition: which is necessary because |
Member
|
Woah that is bad.. thanks for the catch |
Member
|
Thanks for spotting this, this is a pretty heinous bug. I've manually added the fix instead of merging due to conflicts when merging into the next branch. (See readme for details, but generally all PR should be merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the case where no item is selected. Because in this case $parentMenu is still something else than $menu.