Properly set the dropdown value when dealing with remote loaded choices#2573
Merged
jlukic merged 1 commit intoSemantic-Org:nextfrom Jul 10, 2015
davialexandre:fix_remote_select_dropdown
Merged
Properly set the dropdown value when dealing with remote loaded choices#2573jlukic merged 1 commit intoSemantic-Org:nextfrom davialexandre:fix_remote_select_dropdown
jlukic merged 1 commit intoSemantic-Org:nextfrom
davialexandre:fix_remote_select_dropdown
Conversation
This problem happens only when we have a dropdown created from a select that loads remote content. In this scenario, we don't know in advance which choices will be available, so we start with a select without any options. When an choice is selected, module.set.value will try to set the select value, but it will fail, since there's no options. To fix this, module.set.value will add a new option to the select, before setting the value. This will be done only if the dropdown input is a select and if we are dealing with remote loaded content.
jlukic
added a commit
that referenced
this pull request
Jul 10, 2015
Properly set the dropdown value when dealing with remote loaded choices
Member
|
On review it seems it should do if either |
jlukic
added a commit
that referenced
this pull request
Jul 10, 2015
jlukic
added a commit
that referenced
this pull request
Jul 10, 2015
Contributor
Author
|
It makes sense. The only problem I see is that e61b39c ended up duplicating code. Both module.set.value and module.add.value now have this: if($input.is('select')) {
if(settings.allowAdditions || settings.apiSettings) {
module.debug('Adding value to select', addedValue, newValue, $input);
module.add.optionValue(addedValue);
}
}What about moving this check to module.set.selected, inside the $selectedItem.each callback? I think it is a good way to remove this duplication. |
jlukic
added a commit
that referenced
this pull request
Jul 20, 2015
…selected. Consolidated checks into has conditions
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This problem happens only when we have a dropdown created from a select
that loads remote content. In this scenario, we don't know in advance
which choices will be available, so we start with a select without any
options. When an choice is selected, module.set.value will try to set
the select value, but it will fail, since there's no options.
To fix this, module.set.value will add a new option to the select, before
setting the value. This will be done only if the dropdown input is a select
and if we are dealing with remote loaded content.