Skip to content

No More CrazyFun!#16972

Merged
titusfortner merged 1 commit intotrunkfrom
crazy-fun
Jan 22, 2026
Merged

No More CrazyFun!#16972
titusfortner merged 1 commit intotrunkfrom
crazy-fun

Conversation

@titusfortner
Copy link
Member

@titusfortner titusfortner commented Jan 22, 2026 •
edited
Loading

@shs96c you want to do the honors of merging this one?

User description

💥 What does this PR do?

Removes the legacy/original CrazyFun build system files

🔧 Implementation Notes

None of this is needed for anything anymore

💡 Additional Considerations

I have a bunch of other cleanup PRs incoming, but figured this would be the first.

🔄 Types of changes

  • Cleanup (formatting, renaming)

PR Type

Enhancement

Description

  • Removes legacy CrazyFun build system files

  • Eliminates obsolete build grammar and parser code

  • Cleans up deprecated rake task mappings

  • Simplifies Rakefile by removing CrazyFun initialization

Diagram Walkthrough

flowchart LR
  CF["CrazyFun Build System<br/>(Legacy)"]
  Grammar["Grammar Files<br/>(build_grammar.rb, .rl)"]
  Mappings["Rake Mappings<br/>(tasks, handlers)"]
  Rakefile["Rakefile<br/>(initialization code)"]
  Removed["Removed"]
  
  CF --> Grammar
  CF --> Mappings
  CF --> Rakefile
  Grammar --> Removed
  Mappings --> Removed
  Rakefile --> Removed
Loading

File Walkthrough
Relevant files
Cleanup
15 files
build_grammar.rb
Remove generated build grammar parser                                       
+0/-624 
main.rb
Remove build file parsing classes                                               
+0/-185 
file_copy_hack.rb
Remove file copy utility module                                                   
+0/-19   
rake_mappings.rb
Remove rake mappings coordinator                                                 
+0/-21   
check_file_preconditions.rb
Remove file task precondition checker                                       
+0/-17   
check_preconditions.rb
Remove task precondition validator                                             
+0/-13   
create_file_task.rb
Remove file task creator                                                                 
+0/-21   
create_short_task.rb
Remove short task creator                                                               
+0/-19   
create_task.rb
Remove task creator handler                                                           
+0/-13   
tasks.rb
Remove base tasks class                                                                   
+0/-233 
crazy_fun.rb
Remove CrazyFun orchestrator                                                         
+0/-76   
detonating_handler.rb
Remove detonating handler                                                               
+0/-9     
base_grammar.rl
Remove base grammar definition                                                     
+0/-31   
build_grammar.rl
Remove build grammar source                                                           
+0/-96   
Rakefile
Remove CrazyFun initialization and requires                           
+0/-36   

@selenium-ci selenium-ci added the B-build Includes scripting, bazel and CI integrations label Jan 22, 2026
@qodo-code-review
Copy link
Contributor

qodo-code-review bot commented Jan 22, 2026

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
⚪
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-code-review
Copy link
Contributor

qodo-code-review bot commented Jan 22, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

shs96c
shs96c approved these changes Jan 22, 2026
View reviewed changes
Copy link
Member

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ LGTM

@titusfortner titusfortner merged commit 5e9c889 into trunk Jan 22, 2026
25 checks passed
@titusfortner titusfortner deleted the crazy-fun branch January 22, 2026 16:32
@titusfortner titusfortner mentioned this pull request Jan 22, 2026
Merged
titusfortner added a commit that referenced this pull request Jan 22, 2026
@titusfortner
No More CrazyFun! (#16972)
e6c197a 
[build] remove CrazyFun build tooling
titusfortner added a commit that referenced this pull request Jan 23, 2026
@titusfortner
No More CrazyFun! (#16972)
7a5ea59 
[build] remove CrazyFun build tooling
This was referenced Feb 20, 2026
Merged
Closed
Closed
Open
Closed
Closed
Closed
Merged
Merged
Merged
Merged
Closed
Merged
Closed
Closed
This was referenced Feb 23, 2026
Open
Open
Open
Open
Open
Open
Merged
Merged
Merged
Closed
Open
Merged
Closed
This was referenced Mar 8, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shs96c shs96c shs96c approved these changes

@cgoldberg cgoldberg cgoldberg approved these changes

@AutomatedTester AutomatedTester Awaiting requested review from AutomatedTester

@jimevans jimevans Awaiting requested review from jimevans

Assignees

No one assigned

Labels

B-build Includes scripting, bazel and CI integrations Review effort 2/5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@titusfortner @shs96c @cgoldberg @selenium-ci