[rust] Include arguments for skipping drivers and browsers in path#14444
Merged
[rust] Include arguments for skipping drivers and browsers in path#14444
Conversation
Contributor
PR Reviewer Guide 🔍
|
Contributor
PR Code Suggestions ✨
|
Contributor
CI Failure Feedback 🧐(Checks updated until commit e289487)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR: where Configuration options
See more information about the |
M1troll
pushed a commit
to M1troll/selenium
that referenced
this pull request
May 14, 2025
…eleniumHQ#14444) * [rust] Include arguments for skipping drivers and browsers in path * [rust] Update skip logic with the current codebase --------- Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Description
This PR implements a couple of new arguments in Selenium Manager:
--skip_driver_in_path: For not using the drivers found in the PATH.--skip_browser_in_path: For not using the browsers found in the PATH.As usual, these arguments can be enabled using the config file or environment variables (e.g.,
SE_SKIP_DRIVER_IN_PATH=true).The following executions showcase its use:
Usual execution with (incompatible) driver in path:
Same execution with (incompatible) driver in the path but using
--skip_driver_in_path:Motivation and Context
It implements #12985. It reuses the code from #12960.
Types of changes
Checklist
PR Type
enhancement
Description
--skip_driver_in_pathand--skip_browser_in_pathto allow users to skip using drivers and browsers found in the PATH.ManagerConfigto include new boolean fields for skipping drivers and browsers in the PATH.Changes walkthrough 📝
config.rs
Add skip driver and browser in path options to ManagerConfigrust/src/config.rs
skip_driver_in_pathandskip_browser_in_pathboolean fields toManagerConfig.ManagerConfigimplementation to include new fields.lib.rs
Implement logic to skip drivers and browsers in PATHrust/src/lib.rs
browsers.
main.rs
Add CLI options to skip drivers and browsers in PATHrust/src/main.rs
skip_driver_in_pathandskip_browser_in_path.