I noticed that edge still tried to execute the fedcm integration tests even though is only for chrome so I adjusted that and I moved the integration tests to the chrome folder

Actually, I think what you were seeing is that your implementation actually works in Edge, while you marked it to work only in Chrome. You should move the tests back from Chrome folder and mark it as only: {browser: %w[chrome edge]}. The error in CI was suggesting that:

expected pending 'Test guarded; Guarded by {:browser=>:chrome, :reason=>"No reason given"};' to fail. No error was raised.

{browser: %w[chrome edge]}

I noticed that edge still tried to execute the fedcm integration tests even though is only for chrome so I adjusted that and I moved the integration tests to the chrome folder

Actually, I think what you were seeing is that your implementation actually works in Edge, while you marked it to work only in Chrome. You should move the tests back from Chrome folder and mark it as only: {browser: %w[chrome edge]}. The error in CI was suggesting that:

expected pending 'Test guarded; Guarded by {:browser=>:chrome, :reason=>"No reason given"};' to fail. No error was raised.

Thank you so much for the explanation, what throw me off before is that I tried this, but now that I looked more into the Guard implementation, this works and the test pass both with edge and chrome:

describe FedCM, exclusive: [{bidi: false, reason: 'Not yet implemented with BiDi'}, {browser: %i[chrome edge]}]

Is there anything I can do to help this get merged? All the ruby tests seemed to have passed in the last run, @p0deje @titusfortner

PR Reviewer Guide 🔍

PR Code Suggestions ✨

-LOGIN_STATE_SIGNIN: String
-LOGIN_STATE_SIGNUP: String
+LOGIN_STATE_SIGNIN: String = "signin"
+LOGIN_STATE_SIGNUP: String = "signup"
 

-expect(dialog.click).to be_nil
+expect(bridge).to receive(:click_fedcm_dialog_button)
+dialog.click
 

-expect(dialog.cancel).to be_nil
+expect(bridge).to receive(:cancel_fedcm_dialog)
+dialog.cancel
 

-execute(:get_fedcm_title).fetch('subtitle', nil)
+execute(:get_fedcm_subtitle).fetch('subtitle', nil)
 

 def select_account: (Integer index) -> Remote::Response?
 
+def handle_error: (String error_message) -> void
+

-it 'clicks the dialog', skip: 'Investigate IDP config issue' do
+it 'clicks the dialog' do
 

+def fedcm_account_list: -> [FedCM::Account]
+
+def fedcm_dialog_type: -> String
+
+def fedcm_subtitle: -> String?
+
+def fedcm_title: -> String
+
+def reset_fedcm_cooldown: -> nil
+
+def select_fedcm_account: -> nil
+
 def cancel_fedcm_dialog: -> nil
 
 def click_fedcm_dialog_button: -> nil
 
+def fedcm_delay: -> bool
+

Thank you for the contribution!