[JS] Fixes unzipping files into target location#13388
Merged
harsha509 merged 4 commits intoSeleniumHQ:js_downloadfrom Jan 3, 2024
harsha509:js_download
Merged
[JS] Fixes unzipping files into target location#13388harsha509 merged 4 commits intoSeleniumHQ:js_downloadfrom harsha509:js_download
harsha509 merged 4 commits intoSeleniumHQ:js_downloadfrom
harsha509:js_download
Conversation
titusfortner
added a commit
that referenced
this pull request
Jan 3, 2024
* error if downloads are not enabled * unzip and download file to provided directory * getDownloadableFiles returns the names directly * fix unzipping files into target location (#13388) --------- Co-authored-by: harsha509 <sri_harsha509@hotmail.com> Co-authored-by: Sri Harsha <12621691+harsha509@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist