[rb] Extend RBS support for logger and log entry#13192
Merged
titusfortner merged 9 commits intoSeleniumHQ:trunkfrom Nov 27, 2023
Merged
[rb] Extend RBS support for logger and log entry#13192titusfortner merged 9 commits intoSeleniumHQ:trunkfrom
titusfortner merged 9 commits intoSeleniumHQ:trunkfrom
Conversation
…nto rb-update-logger-types
Member
|
The Logger class does not actually use the LogEntry class, so these are actually unrelated. That said, if this fixes an error, we might as well get it merged, thanks! |
Contributor
Author
So the way I'm expanding RBS support is just by looking at the result of the Steep check and fixed the issues, My idea is to continue updating the type support in small PRs, containing two or three classes, so eventually when 'steep check' is run, there are no type issues |
dev-velo
pushed a commit
to dev-velo/selenium
that referenced
this pull request
Nov 29, 2023
* Extend RBS support for logger and log entry * Update allowed to match the instance type * Change as_json to untyped and nillable --------- Co-authored-by: aguspe <agustin.pe94@gmail.com> Co-authored-by: Titus Fortner <titusfortner@users.noreply.github.com>
Merged
8 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR expands RBS support for the following classes:
It also adds support for the standard library 'Forwardable' on the Steepfile
After the update on the RBS files for the LogEntry class this is the result:
The logger class keeps producing an error due to the proc signature coming from logger.formatted = not being identified, even though is part of the standard library:
Motivation and Context
This change expands the work done on: #12844
The main motivation behind it comes from: #10943
Types of changes
Checklist