Refactor frame method to use isEmpty for list check and String check.#12894
Merged
titusfortner merged 1 commit intoSeleniumHQ:trunkfrom Oct 8, 2023
Merged
Refactor frame method to use isEmpty for list check and String check.#12894titusfortner merged 1 commit intoSeleniumHQ:trunkfrom
titusfortner merged 1 commit intoSeleniumHQ:trunkfrom
Conversation
- Replace `frameElements.size() == 0` with `frameElements.isEmpty()` in the `frame` method of `RemoteWebDriver`. This change improves code readability and adheres to best practices for checking if a list is empty.
Member
|
Thank you. |
aguspe
pushed a commit
to aguspe/selenium
that referenced
this pull request
Oct 22, 2023
…SeleniumHQ#12894) Refactor frame method to use isEmpty for list check - Replace `frameElements.size() == 0` with `frameElements.isEmpty()` in the `frame` method of `RemoteWebDriver`. This change improves code readability and adheres to best practices for checking if a list is empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
frameElements.size() == 0withframeElements.isEmpty()in theframemethod ofRemoteWebDriver.This change improves code readability and adheres to best practices for checking if a list is empty.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Refactor in RemoteWebDriver:
Updated the frame method to use isEmpty() instead of size() == 0 for checking if a list is empty.
Refactor in Platform Initialization:
Replaced "".equals(platformString) with platformString.isEmpty() for checking if a string is empty during the platform initialization.
Motivation and Context
The primary motivation behind these changes is to improve the code quality by enhancing readability and adhering to Java's best practices. The existing code, while functional, had areas where readability and maintainability could be improved.
Types of changes
Checklist