Conversation
Member
|
Do we need to fix the Firefox tests before merging this? Seems Chrome usually passes after a retry. |
Member
Author
|
The issue is on trunk as well. Somehow we're losing the geckodriver connection and I don't know why. It passes locally, and usually passes on retry. |
Member
|
Yes, I was running them locally and they all pass. Strange. |
diemol
approved these changes
Jul 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependencies
Don't evaluate this PR until the following have been merged:* #12342* #12343* Also I think this breaks Appium so I need to redo it without changing all the method parameters.Description
Motivation and Context
Considerations
This is not backwards compatible from the standpoint that if a user started the service with a random path and it wasn't valid, the code would ignore it and look on PATH or use Selenium Manager. This was a bug (#12301)