Skip to content

[dotnet] remove hard coded service parameters from test environment #12343

Merged
titusfortner merged 1 commit intotrunkfrom
net_hard_coded
Jul 12, 2023
Merged

[dotnet] remove hard coded service parameters from test environment #12343
titusfortner merged 1 commit intotrunkfrom
net_hard_coded

Conversation

@titusfortner
Copy link
Copy Markdown
Member

@titusfortner titusfortner commented Jul 12, 2023 •
edited
Loading

Description

  • Removed all hard coded references to driver and browser locations
  • I may have gotten a little delete happy and deleted *all Service parameters from all driver creation test code. We aren't modifying service objects anywhere in the code so it is unneeded

Motivation and Context

  • If a User passes in a location for a driver and that driver is wrong, Selenium should error ([🐛 Bug]: Selenium Manager and.NET #12301)
  • .NET tests hard code a default location for drivers and ignore it if it isn't found, which means we can't run tests if we throw an error
  • Besides, Selenium Manager makes it all unnecessary

Only changes test files

@titusfortner titusfortner added the C-dotnet .NET Bindings label Jul 12, 2023
@titusfortner titusfortner mentioned this pull request Jul 12, 2023
Merged
@titusfortner titusfortner merged commit 3fbd0e5 into trunk Jul 12, 2023
@titusfortner titusfortner deleted the net_hard_coded branch July 12, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

C-dotnet .NET Bindings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@titusfortner