Skip to content

[java] log exception message#11922

Merged
diemol merged 2 commits intotrunkfrom
log_exception
Apr 20, 2023
Merged

[java] log exception message#11922
diemol merged 2 commits intotrunkfrom
log_exception

Conversation

@titusfortner
Copy link
Copy Markdown
Member

@titusfortner titusfortner commented Apr 20, 2023

Implements #11645

Code:

    ChromeOptions options = new ChromeOptions();
    options.setCapability("invalid", "value");
    WebDriver driver = new ChromeDriver(options);

Logging Current:

FINE: Executing: newSession [null, newSession {capabilities=[Capabilities {browserName: chrome, goog:chromeOptions: {args: [--remote-allow-origins=*], extensions: []}, invalid: value}]}]
FINE: Exception: [null, newSession {capabilities=[Capabilities {browserName: chrome, goog:chromeOptions: {args: [--remote-allow-origins=*], extensions: []}, invalid: value}]}]

Logging with PR:

FINE: Executing: newSession [null, newSession {capabilities=[Capabilities {browserName: chrome, goog:chromeOptions: {args: [--remote-allow-origins=*], extensions: []}, invalid: value}]}]
FINE: Exception: newSession Illegal key values seen in w3c capabilities: [invalid]

@titusfortner titusfortner added the C-java Java Bindings label Apr 20, 2023
@titusfortner titusfortner requested a review from diemol April 20, 2023 14:20
@diemol diemol merged commit 93fa5f9 into trunk Apr 20, 2023
@diemol diemol deleted the log_exception branch April 20, 2023 14:55
oriongonza pushed a commit to oriongonza/selenium that referenced this pull request Apr 24, 2023
@titusfortner @OrionGonzalez
[java] log exception message (SeleniumHQ#11922)
f70d497 
Fixes SeleniumHQ#11645
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diemol diemol diemol approved these changes

Assignees

No one assigned

Labels

C-java Java Bindings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@titusfortner @diemol