add unicode tests#153
Closed
escapewindow wants to merge 2 commits intoSecurityInnovation:masterfrom
escapewindow:unicode
Closed
add unicode tests#153escapewindow wants to merge 2 commits intoSecurityInnovation:masterfrom escapewindow:unicode
escapewindow wants to merge 2 commits intoSecurityInnovation:masterfrom
escapewindow:unicode
Conversation
UnicodeDecodeError on py3
Author
|
More discussion in #154. |
Commod0re
added a commit
that referenced
this pull request
Feb 27, 2016
- added additional unicode tests - #153 - fixed mixin/base class ordering of PGPObject subclasses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR doesn't fix the issue, but it highlights the issue.
In py3, if a unicode string with special characters, e.g. "Hello \U0001F4A9!", is passed through PGPMessage.new(), it results in a munged string that cannot be decoded again.
The bug is somewhere in PGPObject.text_to_bytes. I haven't tracked it down yet.
The current workaround is to encode the unicode string into a bytearray before passing it to PGPMessage.new(), since text_to_bytes passes bytearrays through: https://github.com/SecurityInnovation/PGPy/blob/master/pgpy/types.py#L230
These tests work in py27, but are broken in py35 until text_to_bytes is fixed.