Add zizmor security scanning and improve CI/CD security#315
Merged
vonericsen merged 3 commits intoSeagate:developfrom Apr 14, 2026
Merged
Add zizmor security scanning and improve CI/CD security#315vonericsen merged 3 commits intoSeagate:developfrom
vonericsen merged 3 commits intoSeagate:developfrom
Conversation
…CI/CD security Signed-off-by: James Fantin-Hardesty <24646452+jfantinhardesty@users.noreply.github.com>
Signed-off-by: James Fantin-Hardesty <24646452+jfantinhardesty@users.noreply.github.com>
vonericsen
approved these changes
Apr 14, 2026
Signed-off-by: James Fantin-Hardesty <24646452+jfantinhardesty@users.noreply.github.com>
Contributor
|
Thanks for these changes! |
vonericsen
pushed a commit
that referenced
this pull request
Apr 15, 2026
* Add zizmor to github actions and fix warnings from zizmor to improve CI/CD security Signed-off-by: James Fantin-Hardesty <24646452+jfantinhardesty@users.noreply.github.com> * Update publish step to use GitHub CLI for release management. Signed-off-by: James Fantin-Hardesty <24646452+jfantinhardesty@users.noreply.github.com> * Update opensea-common subproject to latest commit Signed-off-by: James Fantin-Hardesty <24646452+jfantinhardesty@users.noreply.github.com> --------- Signed-off-by: James Fantin-Hardesty <24646452+jfantinhardesty@users.noreply.github.com> Signed-off-by: Tyler Erickson <tyler.erickson@seagate.com> # Conflicts: # .github/workflows/meson.yml # .github/workflows/msbuild.yml # .github/workflows/source-release.yml # subprojects/opensea-common
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Zizmor to the CI/CD pipeline. Zizmor is a tool that scans GitHub Actions and then finds security issues with the way they are setup. We have been using it in our cloudfuse project for a few months and found it very useful. This can help prevent compromises to released packages, etc. that have been becoming very common in the past few months.
I also took a stab at trying to apply fixes for the issues it identified. There are likely a few issues here than can only be identified when running the CI/CD pipelines. Hoping we can have a bit of a back and forth to fix any issues with the runs.