Skip to content

fix(viewer): make asset navigation instantaneous#2539

Merged
nicomiguelino merged 4 commits intoScreenly:masterfrom
nicomiguelino:fix-viewer-asset-control
Oct 22, 2025
Merged

fix(viewer): make asset navigation instantaneous#2539
nicomiguelino merged 4 commits intoScreenly:masterfrom
nicomiguelino:fix-viewer-asset-control

Conversation

@nicomiguelino
Copy link
Contributor

@nicomiguelino nicomiguelino commented Oct 18, 2025

Issues Fixed

Description

  • Replace SIGUSR1 signal with threading.Event
  • Enable immediate skipping during asset playback
  • Improve responsiveness when switching assets

Checklist (General)

  • I have performed a self-review of my own code.
  • New and existing unit tests pass locally and on CI with my changes.
  • I have done an end-to-end test for Raspberry Pi devices.
  • I have tested my changes for x86 devices.
  • I added a documentation for the changes I have made (when necessary).

Checklist (Details)

  • 🐞 Make switching to previous or next assets instantaneous when a video asset is currently being played.

- Replace SIGUSR1 signal with threading.Event
- Enable immediate skipping during asset playback
- Improve responsiveness when switching assets
- Replace sh.Command with subprocess.Popen for ffplay
- Use skip event timeout for video playback duration
- Enable immediate stopping of video playback
- Remove unused imports from media_player and utils
- Fix line length for logging statements
- Reorganize imports alphabetically
- Remove TestSignalHandlers class
- Signal-based approach replaced with threading.Event
@sonarqubecloud
Copy link

nicomiguelino added a commit to nicomiguelino/Anthias that referenced this pull request Oct 19, 2025
@nicomiguelino nicomiguelino marked this pull request as ready for review October 22, 2025 19:55
@nicomiguelino nicomiguelino requested a review from a team as a code owner October 22, 2025 19:55
@nicomiguelino nicomiguelino merged commit 992e33f into Screenly:master Oct 22, 2025
8 checks passed
@nicomiguelino nicomiguelino deleted the fix-viewer-asset-control branch October 22, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant