Skip to content

fix: ensure authentication for the device settings endpoint#2264

Merged
nicomiguelino merged 1 commit intoScreenly:masterfrom
nicomiguelino:update-device-settings-endpoint
Apr 15, 2025
Merged

fix: ensure authentication for the device settings endpoint#2264
nicomiguelino merged 1 commit intoScreenly:masterfrom
nicomiguelino:update-device-settings-endpoint

Conversation

@nicomiguelino
Copy link
Contributor

@nicomiguelino nicomiguelino commented Apr 15, 2025

Issues Fixed

  • If basic authentication is enabled, anyone can still access the /api/v2/device_settings

Description

  • Adds the authorized decorator to the endpoint function

Checklist

  • I have performed a self-review of my own code.
  • New and existing unit tests pass locally and on CI with my changes.
  • I have done an end-to-end test for Raspberry Pi devices.
  • I have tested my changes for x86 devices.
  • I added a documentation for the changes I have made (when necessary).

@sonarqubecloud
Copy link

@nicomiguelino nicomiguelino marked this pull request as ready for review April 15, 2025 16:08
@nicomiguelino nicomiguelino requested a review from a team as a code owner April 15, 2025 16:08
@nicomiguelino nicomiguelino merged commit fe68fc2 into Screenly:master Apr 15, 2025
8 checks passed
@nicomiguelino nicomiguelino deleted the update-device-settings-endpoint branch April 15, 2025 16:09
nicomiguelino added a commit to nicomiguelino/Anthias that referenced this pull request Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant