Compatibility with DBAL4 for MAriaDB functions#120
Merged
Hikariii merged 2 commits intoScientaNL:masterfrom Oct 17, 2024
Merged
Compatibility with DBAL4 for MAriaDB functions#120Hikariii merged 2 commits intoScientaNL:masterfrom
Hikariii merged 2 commits intoScientaNL:masterfrom
Conversation
annervisser
reviewed
Oct 8, 2024
Contributor
annervisser
left a comment
There was a problem hiding this comment.
@Hikariii This would expose all mysql functions for all mysql-likes (mysql & mariadb)
This effectively makes mariadb a superset of mysql.
I'd be fine with this change, mariadb seems to support all json function mysql does.
In addition we should move JSON_VALUE from mariadb to mysql, since both support it
|
I have tested this change too on a small project and seem to work.
This PR will be much apreciated 😃 |
annervisser
added a commit
that referenced
this pull request
Oct 17, 2024
Reimplementation of PR #120 with backwards compatibility
Reimplementation of PR ScientaNL#120 with backwards compatibility Fixes ScientaNL#116 Fixes ScientaNL#117 Co-authored-by: Jakub Caban <kuba.iluvatar@gmail.com>
09ee909 to
64ed486
Compare
Contributor
|
@Lustmored Thanks for your PR. I've updated it to add backwards compatibility with older versions of DBAL. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple PR solves #116 and #117. The root cause here is that since DBAL 4 MAriaDB platforms are no longer extending MySQL platform, but only
AbstractMySQLPlatform. Therefore functions that are identical between MariaDB and MySQL dialects became unusable withOperation "JSON_CONTAINS" is not supported by platform.or similar.I have tested this change on an existing and pretty large project and everything seems to be working as expected.