add pyproject.toml and remove setup.py #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Would be curious as to what @trexfeathers and @pp-mo think of the keywords (line 38) and description (line 37) for iris-grib as I don't think that this is my call to make. |
* upstream/main: Improve pre-commit compliance (SciTools#406) Add pre-commit config (SciTools#400) pdt6 & gdt140 take *three* (SciTools#401) v0x19 docs update (SciTools#370) bump feature branch to release version 0.19.0 (SciTools#364)
trexfeathers
requested changes
Apr 11, 2024
Contributor
trexfeathers
left a comment
There was a problem hiding this comment.
Nice work @HGWright!
I've been through the new file, the old file, and the documentation for pyproject.toml and setuptools. Here is what I have...
This reverts commit 6f99210.
`pyproject.toml` decisions for the Iris-grib leads
trexfeathers
approved these changes
Apr 11, 2024
Contributor
|
Let's gooooo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove setup.py and replace it with a pyproject.toml file. This is for alignment with the rest of SciTools and we think that this is the better way to do it.
closes #387