Skip to content

pdt6 & gdt140 take *three* #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
trexfeathers merged 6 commits into from
Apr 9, 2024
Merged

pdt6 & gdt140 take *three* #401

trexfeathers merged 6 commits into from
Apr 9, 2024

Conversation

@pp-mo
Copy link
Member

@pp-mo pp-mo commented Apr 8, 2024

Replacing #295, since that also went stale. Both due to drift in main branch, and also the adoption of #343 which implemented part of what the original PR did (phew!)
Effectively just rebasing #295, with related changes matching changes-since in the main branch.

N.B. this now only adds the pdt6 support, since #343 already fixed gdt140.

@CLAassistant
Copy link

CLAassistant commented Apr 8, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@pp-mo pp-mo changed the title pdt6 & gdt140 take ***three*** pdt6 & gdt140 take **three** Apr 8, 2024
@pp-mo pp-mo changed the title pdt6 & gdt140 take **three** pdt6 & gdt140 take *three* Apr 8, 2024
@pp-mo pp-mo requested a review from trexfeathers April 8, 2024 16:00
@pp-mo pp-mo closed this Apr 8, 2024
@pp-mo pp-mo reopened this Apr 8, 2024
@pp-mo
Copy link
Member Author

pp-mo commented Apr 8, 2024

Hi @marqh you can see that we're finally trying to adopt that code you proposed ages ago !
But this needs your agreement to the new CLA, since we changed it.

Or, if it seems more appropriate, I think you can make your membership of https://github.com/MetOffice "public", in which case that in itself should satisfy the CLA checker (see its detailed terms).

trexfeathers
trexfeathers requested changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used our implementation of template 4.1 as my basis, since officially-speaking it seems to be defined in an identical way except for the swapping of ensemble information for percentile information.

@marqh
Copy link
Member

marqh commented Apr 9, 2024

Hi @marqh you can see that we're finally trying to adopt that code you proposed ages ago ! But this needs your agreement to the new CLA, since we changed it.

Or, if it seems more appropriate, I think you can make your membership of https://github.com/MetOffice "public", in which case that in itself should satisfy the CLA checker (see its detailed terms).

Hi @pp-mo
i've updated user membership status, in the hope that this would justWork™
but the license/cla is still pending
i am content to agree to a CLA, but just wanted to check if this is redundant, given membership change
all ther best, m

@trexfeathers
Copy link
Contributor

trexfeathers commented Apr 9, 2024

Hi @marqh you can see that we're finally trying to adopt that code you proposed ages ago ! But this needs your agreement to the new CLA, since we changed it.
Or, if it seems more appropriate, I think you can make your membership of https://github.com/MetOffice "public", in which case that in itself should satisfy the CLA checker (see its detailed terms).

Hi @pp-mo i've updated user membership status, in the hope that this would justWork™ but the license/cla is still pending i am content to agree to a CLA, but just wanted to check if this is redundant, given membership change all ther best, m

Thanks for getting back to us @marqh! You still are not appearing in the publicly accessible list - view this page in an incognito window - which is what the CLA Assistant needs so it can confirm you are Met Office person. Was this the guidance you followed?

@marqh
Copy link
Member

marqh commented Apr 9, 2024

Was this the guidance you followed?

yes
it says public on my authorised session and doesn't have me on an incognito session
i am confused (sorry)

@trexfeathers
Copy link
Contributor

trexfeathers commented Apr 9, 2024

Was this the guidance you followed?

yes it says public on my authorised session and doesn't have me on an incognito session i am confused (sorry)

Could this possibly be due to a confusion between @marqh and @mo-marqh?

@pp-mo pp-mo force-pushed the myeo__lambert-azimuthal__rebased branch from 999bc95 to fc870f5 Compare April 9, 2024 16:18
@trexfeathers trexfeathers merged commit 91145eb into SciTools:main Apr 9, 2024
@trexfeathers trexfeathers mentioned this pull request Apr 9, 2024
Closed
HGWright added a commit to HGWright/iris-grib that referenced this pull request Apr 11, 2024
@HGWright
Merge remote-tracking branch 'upstream/main' into pyproj
6e9cf2f 
* upstream/main:
  Improve pre-commit compliance (SciTools#406)
  Add pre-commit config (SciTools#400)
  pdt6 & gdt140 take *three* (SciTools#401)
  v0x19 docs update (SciTools#370)
  bump feature branch to release version 0.19.0 (SciTools#364)
@trexfeathers trexfeathers mentioned this pull request Aug 30, 2024
Merged
@pp-mo pp-mo deleted the myeo__lambert-azimuthal__rebased branch November 29, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trexfeathers trexfeathers trexfeathers approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pp-mo @CLAassistant @marqh @trexfeathers @mo-marqh