Default tests to the 'agg' matplotlib backend. #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @rhattersley just out of interest, whats the drive for changing from TkAgg (default)? Maybe it should be listed under the description of the issue. |
Member
|
@cpelley - TkAgg is not the default on all platforms. Agg appears to be the canonical backend. See http://github.com/SciTools/cartopy/issues/214 for further info. |
|
ah I see, thanks for the context @esc24 |
Member
|
@rhattersley - I see no issue under OSX with this change. It might be worth updating the docstring (line 24) to highlight the use of agg by default. |
Member
|
👍 |
esc24
added a commit
that referenced
this pull request
Feb 14, 2013
Default tests to the 'agg' matplotlib backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@esc24 / @pelson - are there any cross-platform issues with this?